Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756109AbbFBIwG (ORCPT ); Tue, 2 Jun 2015 04:52:06 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:33367 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755215AbbFBIvz (ORCPT ); Tue, 2 Jun 2015 04:51:55 -0400 Message-ID: <556D6E9C.4050402@linaro.org> Date: Tue, 02 Jun 2015 14:21:40 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Lee Jones CC: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, sameo@linux.intel.com, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, zhaoy Subject: Re: [PATCH 2/4] mfd: 88pm800: use irq_mode to configure interrupt status reg clear method References: <1432937962-4537-1-git-send-email-vaibhav.hiremath@linaro.org> <1432937962-4537-3-git-send-email-vaibhav.hiremath@linaro.org> <20150601083159.GD3329@x1> In-Reply-To: <20150601083159.GD3329@x1> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1883 Lines: 62 On Monday 01 June 2015 02:01 PM, Lee Jones wrote: > On Sat, 30 May 2015, Vaibhav Hiremath wrote: > >> From the spec, bit 1 of reg 0xe (page 0): IN_CLEAR_MODE controls the >> method of clearing interrupt status register of 88pm800; >> >> 0: clear on read >> 1: clear on write >> >> Signed-off-by: zhaoy > > This signed-off is not acceptable. > > No nicknames. Full names only. > I just carry forwarded the signoff from original commit. Let me find his complete signoff and add it to this patch. >> Signed-off-by: Vaibhav Hiremath >> --- >> drivers/mfd/88pm800.c | 4 +++- >> include/linux/mfd/88pm80x.h | 2 ++ >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c >> index 06ee058..8ea4467 100644 >> --- a/drivers/mfd/88pm800.c >> +++ b/drivers/mfd/88pm800.c >> @@ -391,7 +391,8 @@ static int device_irq_init_800(struct pm80x_chip *chip) >> PM800_WAKEUP2_INV_INT | PM800_WAKEUP2_INT_CLEAR | >> PM800_WAKEUP2_INT_MASK; >> >> - data = PM800_WAKEUP2_INT_CLEAR; >> + data = (chip->irq_mode) ? >> + PM800_WAKEUP2_INT_WRITE_CLEAR : PM800_WAKEUP2_INT_READ_CLEAR; > > These variable names are terrible. 'irq_mode' as a bool tells me > nothing. > > What does; irq_mode = 'yes' and irq_mode = 'no' mean? If I didn't > read the remainder of the code, I would assume if it was 'yes' then > the device was in IRQ Mode and if not, it would be in PIO or Polling > mode, but that's not what it means at all is it? > > As for 'data', well, isn't everything data? > I will rename it. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/