Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755887AbbFBJoC (ORCPT ); Tue, 2 Jun 2015 05:44:02 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:10105 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754071AbbFBJnz (ORCPT ); Tue, 2 Jun 2015 05:43:55 -0400 X-IronPort-AV: E=Sophos;i="5.01,1,1399996800"; d="scan'208";a="96277738" Message-ID: <556D7610.6000206@cn.fujitsu.com> Date: Tue, 2 Jun 2015 17:23:28 +0800 From: Gu Zheng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: Andy Lutomirski CC: "H. Peter Anvin" , Andy Lutomirski , Ingo Molnar , Borislav Petkov , Thomas Gleixner , "linux-kernel@vger.kernel.org" , X86 ML Subject: Re: [RFC PATCH] x86, espfix: postpone the initialization of espfix stack for AP References: <1431603465-12610-1-git-send-email-guz.fnst@cn.fujitsu.com> <20150514122621.GB29235@pd.tnic> <20150514182954.GB23479@gmail.com> <20150514212753.GE29125@pd.tnic> <55551E07.8080509@zytor.com> <20150515065417.GB29973@gmail.com> <55559FDA.3010205@zytor.com> <555A40C9.6010605@kernel.org> <555B5105.4040808@zytor.com> <555F0139.9040404@cn.fujitsu.com> <55666D4A.5040006@cn.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.100] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4526 Lines: 115 Hi Andy, Sorry for late reply. On 05/29/2015 09:07 AM, Andy Lutomirski wrote: > On Wed, May 27, 2015 at 6:20 PM, Gu Zheng wrote: >> ping... >> >> On 05/22/2015 06:13 PM, Gu Zheng wrote: >> >>> The following lockdep warning occurs when running with 4.1.0-rc3: >>> [ 3.178000] ------------[ cut here ]------------ >>> [ 3.183000] WARNING: CPU: 128 PID: 0 at kernel/locking/lockdep.c:2755 lockdep_trace_alloc+0xdd/0xe0() >>> [ 3.193000] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) >>> [ 3.199000] Modules linked in: >>> >>> [ 3.203000] CPU: 128 PID: 0 Comm: swapper/128 Not tainted 4.1.0-rc3 #70 >>> [ 3.221000] 0000000000000000 2d6601fb3e6d4e4c ffff88086fd5fc38 ffffffff81773f0a >>> [ 3.230000] 0000000000000000 ffff88086fd5fc90 ffff88086fd5fc78 ffffffff8108c85a >>> [ 3.238000] ffff88086fd60000 0000000000000092 ffff88086fd60000 00000000000000d0 >>> [ 3.246000] Call Trace: >>> [ 3.249000] [] dump_stack+0x4c/0x65 >>> [ 3.255000] [] warn_slowpath_common+0x8a/0xc0 >>> [ 3.261000] [] warn_slowpath_fmt+0x55/0x70 >>> [ 3.268000] [] lockdep_trace_alloc+0xdd/0xe0 >>> [ 3.274000] [] __alloc_pages_nodemask+0xad/0xca0 >>> [ 3.281000] [] ? __lock_acquire+0xf6d/0x1560 >>> [ 3.288000] [] alloc_page_interleave+0x3a/0x90 >>> [ 3.295000] [] alloc_pages_current+0x17d/0x1a0 >>> [ 3.301000] [] ? __get_free_pages+0xe/0x50 >>> [ 3.308000] [] __get_free_pages+0xe/0x50 >>> [ 3.314000] [] init_espfix_ap+0x17b/0x320 >>> [ 3.320000] [] start_secondary+0xf1/0x1f0 >>> [ 3.327000] ---[ end trace 1b3327d9d6a1d62c ]--- >>> >>> This seems a mis-warning by lockdep, as we alloc pages with GFP_KERNEL in >>> init_espfix_ap() which is called before enabled local irq, and the lockdep >>> sub-system considers this behaviour as allocating memory with GFP_FS with >>> local irq disabled, then trigger the warning as mentioned about. >>> >>> Though we could allocate them on the boot CPU side and hand them over to >>> the secondary CPU, but it seems a waste if some of cpus are still offline. >>> As there is no need to these pages(espfix stack) until we try to run user >>> code, so we can postpone the initialization of espfix stack after cpu >>> booted to avoid the noise. > > Does this pass the sigreturn_32 test on both 32-bit and 64-bit kernels > and sigreturn_64 test on 64-bit kernels? (The test is in > tools/testing/selftests/x86.) If so, looks good to me. It failed the test. There seems a bug in this patch, it alloc espfix stack in the do_boot_cpu routine, not in the context of target cpu that we want to boot up, so the simple change is wrong here. I will send the v2 version soon, and it passed the tests you mentioned above. Thanks again for your comments and suggestion. Regards, Gu > > --Andy > >>> >>> Signed-off-by: Gu Zheng >>> --- >>> arch/x86/kernel/smpboot.c | 14 +++++++------- >>> 1 file changed, 7 insertions(+), 7 deletions(-) >>> >>> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c >>> index 50e547e..3ce05de 100644 >>> --- a/arch/x86/kernel/smpboot.c >>> +++ b/arch/x86/kernel/smpboot.c >>> @@ -240,13 +240,6 @@ static void notrace start_secondary(void *unused) >>> check_tsc_sync_target(); >>> >>> /* >>> - * Enable the espfix hack for this CPU >>> - */ >>> -#ifdef CONFIG_X86_ESPFIX64 >>> - init_espfix_ap(); >>> -#endif >>> - >>> - /* >>> * We need to hold vector_lock so there the set of online cpus >>> * does not change while we are assigning vectors to cpus. Holding >>> * this lock ensures we don't half assign or remove an irq from a cpu. >>> @@ -901,6 +894,13 @@ static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle) >>> } >>> } >>> >>> + /* >>> + * Enable the espfix hack for this CPU >>> + */ >>> +#ifdef CONFIG_X86_ESPFIX64 >>> + init_espfix_ap(); >>> +#endif >>> + >>> /* mark "stuck" area as not stuck */ >>> *trampoline_status = 0; >>> >> >> > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/