Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758970AbbFBNSQ (ORCPT ); Tue, 2 Jun 2015 09:18:16 -0400 Received: from mail-oi0-f51.google.com ([209.85.218.51]:33522 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755082AbbFBNSK (ORCPT ); Tue, 2 Jun 2015 09:18:10 -0400 MIME-Version: 1.0 In-Reply-To: References: <1402320115-13171-1-git-send-email-x-linux@infra-silbe.de> <20140613183157.GA24644@kroah.com> <20140707173142.GB8693@kroah.com> Date: Tue, 2 Jun 2015 15:18:09 +0200 Message-ID: Subject: Re: [PATCH] USB: ftdi_sio: add GPIO support From: Linus Walleij To: Grant Likely Cc: Greg Kroah-Hartman , Sascha Silbe , Johan Hovold , Alexandre Courbot , "linux-usb@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 30 On Sat, May 30, 2015 at 10:29 PM, Grant Likely wrote: > On Mon, Jul 7, 2014 at 6:31 PM, Greg Kroah-Hartman > wrote: >>> However is the MFD cell approach acceptable? >> >> Yes it is. > > Going back to this old conversation... Actually, I disagree. There is > absolutely no need to go the MFD approach for this driver. That just > adds layers of abstraction for no purpose. GPIOLIB is an interface, > and it is completely fine for a driver to hook up to the GPIOLIB > interface at the same time as exposing a serial port. MFD doesn't buy > the driver anything useful here. What is buys is centralizing code into the proper drivers/gpio folder of the kernel. So more of a maintenance point than a mechanics/performance point. We do have GPIO drivers scattered all over the kernel so one more or less wouldn't matter so much... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/