Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759258AbbFBN7F (ORCPT ); Tue, 2 Jun 2015 09:59:05 -0400 Received: from www.linutronix.de ([62.245.132.108]:51136 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759019AbbFBN6r (ORCPT ); Tue, 2 Jun 2015 09:58:47 -0400 Date: Tue, 2 Jun 2015 15:58:48 +0200 (CEST) From: Thomas Gleixner To: Peter Zijlstra cc: Viresh Kumar , LKML , Ingo Molnar , Paul McKenney , Frederic Weisbecker , Eric Dumazet , John Stultz , Joonwoo Park , Wenbo Wang , Steven Rostedt , Badhri Jagan Sridharan Subject: Re: [patch 4/7] timer: Replace timer base by a cpu index In-Reply-To: <20150527120914.GZ3644@twins.programming.kicks-ass.net> Message-ID: References: <20150526210723.245729529@linutronix.de> <20150526224511.950084301@linutronix.de> <20150527092236.GC2256@linux> <20150527120914.GZ3644@twins.programming.kicks-ass.net> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 32 On Wed, 27 May 2015, Peter Zijlstra wrote: > On Wed, May 27, 2015 at 02:52:36PM +0530, Viresh Kumar wrote: > > > + timer->flags = (timer->flags & ~TIMER_BASEMASK) | cpu; > > > > Because 'cpu' is used only once in this routine, maybe we can use > > 'new_base->cpu' here and the line will still be exactly 80 columns > > long. > > > > Not sure, but maybe we can create a inline helper for this operation > > as it is repeated at multiple places. > > I suggested bitfields at some point I think. That gets the compiler to > generate those helpers for you. I tried, but they are a PITA for the static initializiers and I could not be bothered to deal with the endianess mess. Maybe I should try again :) Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/