Date: Tue, 2 Jun 2015 15:59:09 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Feng Wu <feng.wu@intel.com>
cc: joro@8bytes.org, dwmw2@infradead.org, jiang.liu@linux.intel.com,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [v8 3/9] iommu, x86: Implement irq_set_vcpu_affinity for
 intel_ir_chip
In-Reply-To: <1432699544-17444-4-git-send-email-feng.wu@intel.com>
Message-ID: <alpine.DEB.2.11.1506021501070.3786@nanos>
References: <1432699544-17444-1-git-send-email-feng.wu@intel.com> <1432699544-17444-4-git-send-email-feng.wu@intel.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1287
Lines: 34

On Wed, 27 May 2015, Feng Wu wrote:
> +	/* stop posting interrupts, back to remapping mode */
> +	if (!vcpu_info) {
> +		modify_irte(&ir_data->irq_2_iommu, &ir_data->irte_entry);
> +	} else {
> +		vcpu_pi_info = (struct vcpu_data *)vcpu_info;
> +
> +		/*
> +		 * "ir_data->irte_entry" saves the remapped format of IRTE,
> +		 * which being a cached irte is still updated when setting
> +		 * the affinity even when we are in posted mode. So this make

s/make/makes/

> +		 * it possible to switch back to remapped mode from posted mode,
> +		 * we can just set "ir_data->irte_entry" to hardware for that
> +		 * purpose. Here we store the posted format of IRTE in another
> +		 * new member "ir_data->irte_pi_entry" to not corrupt

Remove the 'another new member' please. That member is not longer new
once that patch is applied.

Now there is another question. Are we actually using that pi_entry
cached value for anything else than this code here? If not, we can do
this on the stack and avoid the extra storage in ir_data.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/