Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759299AbbFBOQ0 (ORCPT ); Tue, 2 Jun 2015 10:16:26 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:45557 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755649AbbFBOQP (ORCPT ); Tue, 2 Jun 2015 10:16:15 -0400 Message-ID: <556DBAAA.4010408@roeck-us.net> Date: Tue, 02 Jun 2015 07:16:10 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Vivien Didelot , netdev@vger.kernel.org CC: "David S. Miller" , Florian Fainelli , Andrew Lunn , Scott Feldman , Jiri Pirko , Jerome Oufella , linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, Chris Healy Subject: Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring References: <1433208470-25338-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1433208470-25338-6-git-send-email-vivien.didelot@savoirfairelinux.com> In-Reply-To: <1433208470-25338-6-git-send-email-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 722 Lines: 20 On 06/01/2015 06:27 PM, Vivien Didelot wrote: > Disable the mirroring policy in the monitor control register, since this > feature is not needed. > > Signed-off-by: Vivien Didelot Should this be a separate patch, unrelated to the patch set ? If I understand correctly, this effectively disables IGMP/MLD snooping. I think this warrants an explanation why that it not needed, not just a statement that it is not needed. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/