Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758954AbbFBPJZ (ORCPT ); Tue, 2 Jun 2015 11:09:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48035 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753802AbbFBPJR (ORCPT ); Tue, 2 Jun 2015 11:09:17 -0400 Date: Tue, 2 Jun 2015 10:09:15 -0500 From: Josh Poimboeuf To: Miroslav Benes Cc: sjenning@redhat.com, jkosina@suse.cz, vojtech@suse.cz, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, pmladek@suse.cz Subject: Re: [PATCH] livepatch: add module locking around kallsyms calls Message-ID: <20150602150915.GB24773@treble.redhat.com> References: <1433173717-20885-1-git-send-email-mbenes@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1433173717-20885-1-git-send-email-mbenes@suse.cz> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 26 On Mon, Jun 01, 2015 at 05:48:37PM +0200, Miroslav Benes wrote: > The list of loaded modules is walked through in > module_kallsyms_on_each_symbol (called by kallsyms_on_each_symbol). The > module_mutex lock should be acquired to prevent potential corruptions > in the list. > > This was uncovered with new lockdep asserts in module code introduced by > the commit 0be964be0d45 ("module: Sanitize RCU usage and locking") in > recent next- trees. > > Signed-off-by: Miroslav Benes Thanks! Should we add a comment to kallsyms_on_each_symbol() so that others don't make this mistake? Acked-by: Josh Poimboeuf -- Josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/