Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759463AbbFBPNj (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Jun 2015 11:13:39 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:48673 "EHLO
	smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759403AbbFBPNB (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Jun 2015 11:13:01 -0400
Message-ID: <ceda7fbb98cf30c5b60bc54ead29fd80.squirrel@www.codeaurora.org>
In-Reply-To: <1433228366.6844.18.camel@mm-sol.com>
References: <1433190528-30026-1-git-send-email-sviau@codeaurora.org>
    <1433228366.6844.18.camel@mm-sol.com>
Date: Tue, 2 Jun 2015 10:12:59 -0500
Subject: Re: [PATCH v2] drm/msm/hdmi: Use pinctrl in HDMI driver
From: =?iso-8859-1?Q?=22St=E9phane_Viau=22?= <sviau@codeaurora.org>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: "Stephane Viau" <sviau@codeaurora.org>, dri-devel@lists.freedesktop.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        robdclark@gmail.com
User-Agent: SquirrelMail/1.4.22-4.el6
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
X-Priority: 3 (Normal)
Importance: Normal
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2712
Lines: 83

Hi Ivan,

>
> Hi Stephane,
>
> On Mon, 2015-06-01 at 16:28 -0400, Stephane Viau wrote:
>> Some targets (eg: msm8994) use the pinctrl framework to configure
>> interface pins. This change adds support for initialization and
>> pinctrl active/sleep state control for the HDMI driver.
>>
>> Signed-off-by: Stephane Viau <sviau@codeaurora.org>
>> ---
>> v2:
>> - Add devicetree binding documentation for pinctrl property  [Ivan]
>> - Use pinctrl framework's PINCTRL_STATE_DEFAULT/SLEEP states [Ivan]
>>
>
> <snip>
>
>>
>>  static int hdmi_bind(struct device *dev, struct device *master, void
>> *data)
>> @@ -365,6 +379,7 @@ static int hdmi_bind(struct device *dev, struct
>> device *master, void *data)
>>  #ifdef CONFIG_OF
>>         struct device_node *of_node = dev->of_node;
>>         const struct of_device_id *match;
>> +       struct pinctrl *pinctrl;
>>
>>         match = of_match_node(dt_match, of_node);
>>         if (match && match->data) {
>> @@ -383,6 +398,18 @@ static int hdmi_bind(struct device *dev, struct
>> device *master, void *data)
>>         hdmi_cfg->mux_sel_gpio  = get_gpio(dev, of_node,
>> "qcom,hdmi-tx-mux-sel");
>>         hdmi_cfg->mux_lpm_gpio  = get_gpio(dev, of_node,
>> "qcom,hdmi-tx-mux-lpm");
>>
>> +       /* not all targets have pinctrl, do not fail in case of error:
>> */
>> +       pinctrl = devm_pinctrl_get(dev);
>
> Probably I have to be more explicit. Why not using pins binding handled in
> driver
> really_probe()? I have to admit that I am not familiar with DRM subsystem.

This would work, indeed, for default/sleep/idle states.

I actually had in mind that we'd need to keep track of HDMI pinctrl states
because we may need to add a couple more in the near future in order to
independently enable/disable certain parts of the HDMI controller (eg:
HPD, DDC, CEC..).

Each of this HW sub-sections of the controller are driven by a different
"pin" in the downstream driver... But since this is nowhere close to being
upstream-ed yet, I'll go ahead with your idea of using the common pins
binding (v3 to follow).

Thanks,
Stephane.

>
> Regards,
> Ivan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


-- 
Qualcomm Innovation Center, Inc.

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/