From: Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To: Ulf Hansson <ulf.hansson@linaro.org>,
        Alexandre Courbot <acourbot@nvidia.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Guenter Roeck <linux@roeck-us.net>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Usage of restart_handler in pwrseq_emmc
Date: Tue, 02 Jun 2015 17:29:56 +0200
Message-ID: <1789396.sexGZzDeEb@diego>
User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; )
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1186
Lines: 32

Hi,

I'm confused by the pwrseq-emmc registering a restart_handler for resetting an 
emmc in a panic-reboot case at priority 129 to "schedules it just before 
system reboot".

>From what I remember from the restart-handler discussion the actuall usage is 
traversing the ordered list until one registered handler sucessfully restarts 
the system and not to have arbitary actions in there not related to the actual 
restart process?

The actual documentation in kernel/reboot.c supports this assumption, 
describing register_restart_handler as "Register function to be called to 
reset the system".


Additionally, 128 isn't even _the_ priority to reboot the system as described 
above and some drivers use higher priorities per default, see in 
drivers/power/reset arm-versatile-reboot.c; at91-reset.c; rmobile-reset.c and 
some more.


So I guess this should use some other mechanism (reboot notifier) instead of 
restart_handlers?


Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/