Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759545AbbFBR3Y (ORCPT ); Tue, 2 Jun 2015 13:29:24 -0400 Received: from mta01.ornl.gov ([128.219.177.14]:20701 "EHLO mta01.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754729AbbFBR3P convert rfc822-to-8bit (ORCPT ); Tue, 2 Jun 2015 13:29:15 -0400 X-SG: RELAYLIST X-IronPort-AV: E=Sophos;i="5.13,541,1427774400"; d="scan'208";a="104054050" From: "Simmons, James A." To: "'Greg Kroah-Hartman'" , David Decotigny CC: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "HPDD-discuss@lists.01.org" , Amir Shehata , "lustre-devel@lists.lustre.org" Subject: RE: [HPDD-discuss] [PATCH v1] staging: lustre: libcfs: add __user annotation in libcfs_ioctl_data Thread-Topic: [HPDD-discuss] [PATCH v1] staging: lustre: libcfs: add __user annotation in libcfs_ioctl_data Thread-Index: AQHQnNPZv6EI4ZfpVkO7Cxz0qDT7fJ2ZU9xw Date: Tue, 2 Jun 2015 17:29:13 +0000 Message-ID: <6de5257ecd664c898c9108490e989a88@EXCHCS34.ornl.gov> References: <1432615204-4062-1-git-send-email-ddecotig@gmail.com> <20150531022744.GA31012@kroah.com> <20150602013115.GB23940@kroah.com> In-Reply-To: <20150602013115.GB23940@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [128.219.12.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1332 Lines: 26 >>On Mon, Jun 01, 2015 at 12:21:30PM -0700, David Decotigny wrote: >> Thanks for reviewing. >> >> The 2 struct members were not marked as __user, which this patch does >> here. This was causing warnings with copy from/to user (see commit >> description). This patch also propagates the annotation to the couple >> of functions that are using those members. > >Lustre's structures are a total mess of kernel and user pointers and >trying to properly mark them as which they are supposed to be at what >point in time is a very difficult task. People keep trying and get it >wrong, so I suggest just leaving this alone until the developers unwind >the structure mess as that will be necessary for this code to get merged >into the main part of the kernel. Greg is right. The earlier patch set I sent out for the LNet headers address this issue for the LNet layer. I also having patches coming that fix libcfs ioctl handling as well. I see Shuey's patches made it in first so I'm going to have to rebase. I will send out the new patch sets later today. This will be v3 of the patch set. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/