Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752329AbbFBTUR (ORCPT ); Tue, 2 Jun 2015 15:20:17 -0400 Received: from www.linutronix.de ([62.245.132.108]:52586 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018AbbFBTTp (ORCPT ); Tue, 2 Jun 2015 15:19:45 -0400 Date: Tue, 2 Jun 2015 21:19:01 +0200 (CEST) From: Thomas Gleixner To: Jiang Liu cc: Bjorn Helgaas , Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , Randy Dunlap , Yinghai Lu , Borislav Petkov , x86@kernel.org, Konrad Rzeszutek Wilk , Boris Ostrovsky , David Vrabel , Feng Wu , Rasmus Villemoes , Brian Gerst , Rusty Russell , Juergen Gross , Tony Luck , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Ingo Molnar , xen-devel@lists.xenproject.org Subject: Re: [Patch v3 27/36] x86, irq: Use access helper irq_data_get_affinity_mask() In-Reply-To: <1433145945-789-28-git-send-email-jiang.liu@linux.intel.com> Message-ID: References: <1433145945-789-1-git-send-email-jiang.liu@linux.intel.com> <1433145945-789-28-git-send-email-jiang.liu@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 953 Lines: 27 On Mon, 1 Jun 2015, Jiang Liu wrote: > diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c > index 9b62f690b0ff..dfa3a5f5b3d3 100644 > --- a/arch/x86/kernel/apic/vector.c > +++ b/arch/x86/kernel/apic/vector.c > @@ -494,9 +494,8 @@ static int apic_set_affinity(struct irq_data *irq_data, > > err = assign_irq_vector(irq, data, dest); > if (err) { > - struct irq_data *top = irq_get_irq_data(irq); > - > - if (assign_irq_vector(irq, data, top->affinity)) > + if (assign_irq_vector(irq, data, > + irq_data_get_affinity_mask(irq_data))) Does this patch work w/o moving the affinity mask to common data? I doubt so, as you remove the retrieval of 'top'. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/