Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752970AbbFBTYG (ORCPT ); Tue, 2 Jun 2015 15:24:06 -0400 Received: from www.linutronix.de ([62.245.132.108]:52580 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751941AbbFBTTm (ORCPT ); Tue, 2 Jun 2015 15:19:42 -0400 Date: Tue, 2 Jun 2015 21:19:44 +0200 (CEST) From: Thomas Gleixner To: Baolin Wang cc: Arnd Bergmann , John Stultz , heenasirwani@gmail.com, pang.xunlei@linaro.org, LKML , y2038@lists.linaro.org Subject: Re: [PATCH v4 02/25] timekeeping:Introduce the current_kernel_time64() function with timespec64 type In-Reply-To: <1433159393-4629-1-git-send-email-baolin.wang@linaro.org> Message-ID: References: <1433159393-4629-1-git-send-email-baolin.wang@linaro.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1033 Lines: 34 On Mon, 1 Jun 2015, Baolin Wang wrote: Subject line is horrible again. "timekeeping: Introduce current_kernel_time64()" Is precise and sufficient. > This patch adds current_kernel_time64() function with timespec64 type, > and makes current_kernel_time() 'static inline' and moves it to timekeeping.h > file. Again, you describe WHAT the patch is doing first and clutter the changelog with completely irrelevant information. > It is convenient for user to get the current kernel time with timespec64 type, What's conveniant about it? > and delete the current_kernel_time() function easily in timekeeping.h file. That > is ready for 2038 when get the current time. This makes no sense at all. Again you should describe WHY current_kernel_time() must be replaced. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/