Date: Tue, 2 Jun 2015 21:20:18 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Baolin Wang <baolin.wang@linaro.org>
cc: arnd@arndb.de, linux-kernel@vger.kernel.org, y2038@lists.linaro.org
Subject: Re: [PATCH v4 08/25] posix-timers:Convert to the 64bit methods for
 the timer_gettime syscall function
In-Reply-To: <1433159747-4854-1-git-send-email-baolin.wang@linaro.org>
Message-ID: <alpine.DEB.2.11.1506021824450.20347@nanos>
References: <1433159747-4854-1-git-send-email-baolin.wang@linaro.org>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1904
Lines: 54


On Mon, 1 Jun 2015, Baolin Wang wrote:

Can you try to create even longer subject lines with less information?

> This patch introduces the timer_get64 method with itimerspec64
> type for k_clock structure, that makes it ready for the 2038 year.

Right. By the speed this is proceeding it will take about 2038 years
until one of these patches is going to be applied.
 
> Convert to the 64bit method with itimerspec64 type for the
> timer_gettime syscall function, and change the timer_gettime syscall
> implementation.
> 
> Also add a default 64bit method for the timer_get64 pointer of k_clock
> structure, and it will be removed after all the drivers are converted
> to 64bit methods.

This is utter crap, really. The default method is a preliminary of
converting the syscall implementation.

"Subject: posix-timers: Implement y2038 safe timer_get64() callback

 The timer_get() callback in struct k_clock is not year 2038 safe on
 32bit systems. 

 To address this implement a new callback timer_get64() which uses
 struct timespec64 along with a default implementation which is a
 wrapper for the existing timer_get() callback. The default callback
 is installed at registration time for all posix clocks which are not
 yet converted to timer_get64() and will be removed once this is
 completed.

 Use the new callback in __timer_gettime()."

That's how a proper changelog should look like.
 
> +static void default_timer_get64(struct k_itimer *timr,
> +			       struct itimerspec64 *cur_setting64)

Please align the second argument proper:

static void default_timer_get64(struct k_itimer *timr,
				struct itimerspec64 *cur_setting64)

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/