Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752183AbbFBTIz (ORCPT ); Tue, 2 Jun 2015 15:08:55 -0400 Received: from mga02.intel.com ([134.134.136.20]:38364 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751220AbbFBTIt (ORCPT ); Tue, 2 Jun 2015 15:08:49 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,541,1427785200"; d="scan'208";a="739617471" Date: Tue, 2 Jun 2015 12:20:36 -0700 From: Bin Gao To: Ingo Molnar Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Greg Kroah-Hartman , One Thousand Gnomes , Peter Hurley , Jiri Slaby , Borislav Petkov , "Stuart R. Anderson" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c Message-ID: <20150602192036.GA52512@worksta> References: <20150529184123.GB13090@worksta> <20150602115433.GA20697@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150602115433.GA20697@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1076 Lines: 25 On Tue, Jun 02, 2015 at 01:54:33PM +0200, Ingo Molnar wrote: > > * Bin Gao wrote: > > > The arch independent uart8250 early console driver has good support for memory > > mapped and io port based 8250 uarts. Since pci is arch independent so it's > > natural to extend uart8250 to support mem, io and pci. Hence pci uart early > > console in arch/x86/kernel_printk.c by the following commit: 'commit > > 5140fda16051 ("Specify PCI based UART for earlyprintk")' is removed. And its > > equivalent function will be available from uart8250 early console driver. > > In what way have you tested this change, does serial-earlyprintk still work on x86 > after the change? > > Thanks, > > Ingo Yes, this patch was tested with earlyprintk=serial,0x3f8 on my x86 box and the early console worked fine. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/