Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752217AbbFBVHz (ORCPT ); Tue, 2 Jun 2015 17:07:55 -0400 Received: from www.linutronix.de ([62.245.132.108]:53169 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbbFBVHs (ORCPT ); Tue, 2 Jun 2015 17:07:48 -0400 Date: Tue, 2 Jun 2015 23:07:39 +0200 (CEST) From: Thomas Gleixner To: Bin Gao cc: Ingo Molnar , Ingo Molnar , "H. Peter Anvin" , Greg Kroah-Hartman , One Thousand Gnomes , Peter Hurley , Jiri Slaby , Borislav Petkov , "Stuart R. Anderson" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c In-Reply-To: <20150602192036.GA52512@worksta> Message-ID: References: <20150529184123.GB13090@worksta> <20150602115433.GA20697@gmail.com> <20150602192036.GA52512@worksta> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1250 Lines: 33 On Tue, 2 Jun 2015, Bin Gao wrote: > On Tue, Jun 02, 2015 at 01:54:33PM +0200, Ingo Molnar wrote: > > > > * Bin Gao wrote: > > > > > The arch independent uart8250 early console driver has good support for memory > > > mapped and io port based 8250 uarts. Since pci is arch independent so it's > > > natural to extend uart8250 to support mem, io and pci. Hence pci uart early > > > console in arch/x86/kernel_printk.c by the following commit: 'commit > > > 5140fda16051 ("Specify PCI based UART for earlyprintk")' is removed. And its > > > equivalent function will be available from uart8250 early console driver. > > > > In what way have you tested this change, does serial-earlyprintk still work on x86 > > after the change? > > > > Thanks, > > > > Ingo > > Yes, this patch was tested with earlyprintk=serial,0x3f8 on my x86 box and > the early console worked fine. What about the memory mapped uarts which have been source of trouble in the past? Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/