Date: Tue, 2 Jun 2015 23:46:02 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Bin Gao <bin.gao@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
        Peter Hurley <peter@hurleysoftware.com>, Jiri Slaby <jslaby@suse.cz>,
        Borislav Petkov <bp@suse.de>,
        "Stuart R. Anderson" <stuart.r.anderson@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from
 early_prink.c
Message-ID: <20150602214601.GA32082@gmail.com>
References: <20150529184123.GB13090@worksta>
 <20150602115433.GA20697@gmail.com>
 <20150602192036.GA52512@worksta>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150602192036.GA52512@worksta>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1267
Lines: 38


* Bin Gao <bin.gao@linux.intel.com> wrote:

> On Tue, Jun 02, 2015 at 01:54:33PM +0200, Ingo Molnar wrote:
> > 
> > * Bin Gao <bin.gao@linux.intel.com> wrote:
> > 
> > > The arch independent uart8250 early console driver has good support for memory 
> > > mapped and io port based 8250 uarts. Since pci is arch independent so it's 
> > > natural to extend uart8250 to support mem, io and pci. Hence pci uart early 
> > > console in arch/x86/kernel_printk.c by the following commit: 'commit 
> > > 5140fda16051 ("Specify PCI based UART for earlyprintk")' is removed. And its 
> > > equivalent function will be available from uart8250 early console driver.
> > 
> > In what way have you tested this change, does serial-earlyprintk still work on x86 
> > after the change?
> > 
> > Thanks,
> > 
> > 	Ingo
> 
> Yes, this patch was tested with earlyprintk=serial,0x3f8 on my x86 box and
> the early console worked fine.

So the format on x86 used to be:

  earlyprintk=serial,ttyS0,115200

does that work too?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/