Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751960AbbFBXoa (ORCPT ); Tue, 2 Jun 2015 19:44:30 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:38896 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751472AbbFBXoX (ORCPT ); Tue, 2 Jun 2015 19:44:23 -0400 MIME-Version: 1.0 In-Reply-To: <1433281580-8319-1-git-send-email-aduggan@synaptics.com> References: <1433281580-8319-1-git-send-email-aduggan@synaptics.com> Date: Tue, 2 Jun 2015 16:44:22 -0700 X-Google-Sender-Auth: yh-ndSEHuUdZ_GzIbfuGBzK5gpE Message-ID: Subject: Re: [PATCH] HID: i2c-hid: Do not set the ACPI companion field in the HID device From: Benson Leung To: Andrew Duggan Cc: "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jiri Kosina , Benjamin Tissoires , Mika Westerberg Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1674 Lines: 44 On Tue, Jun 2, 2015 at 2:46 PM, Andrew Duggan wrote: > The HID device does not need to know about the ACPI device associated with > the underlying i2c device. Setting the ACPI companion field in the HID device > also has the side effect of causing HID to be set as wake capable, since > acpi_bind_one uses's the companion ACPI device's wakeup flags to set the > device as wake capable. Which results in power/wakeup files in sysfs for > the HID device which do not do anything. > > Signed-off-by: Andrew Duggan Reviewed-by: Benson Leung Tested-by: Benson Leung > --- > drivers/hid/i2c-hid/i2c-hid.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c > index 92d6cdf..0dfb5d1 100644 > --- a/drivers/hid/i2c-hid/i2c-hid.c > +++ b/drivers/hid/i2c-hid/i2c-hid.c > @@ -1019,7 +1019,6 @@ static int i2c_hid_probe(struct i2c_client *client, > hid->driver_data = client; > hid->ll_driver = &i2c_hid_ll_driver; > hid->dev.parent = &client->dev; > - ACPI_COMPANION_SET(&hid->dev, ACPI_COMPANION(&client->dev)); > hid->bus = BUS_I2C; > hid->version = le16_to_cpu(ihid->hdesc.bcdVersion); > hid->vendor = le16_to_cpu(ihid->hdesc.wVendorID); > -- > 2.1.4 > -- Benson Leung Software Engineer, Chrom* OS bleung@chromium.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/