Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752506AbbFBX4z (ORCPT ); Tue, 2 Jun 2015 19:56:55 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:36302 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbbFBX4s (ORCPT ); Tue, 2 Jun 2015 19:56:48 -0400 Message-ID: <556E42BB.4060705@gmail.com> Date: Tue, 02 Jun 2015 16:56:43 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Maciej W. Rozycki" CC: James Hogan , Leonid Yegoshin , linux-mips@linux-mips.org, benh@kernel.crashing.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, Ralf Baechle , markos.chandras@imgtec.com, Steven.Hill@imgtec.com, alexander.h.duyck@redhat.com, "David S. Miller" Subject: Re: [PATCH 1/3] MIPS: R6: Use lightweight SYNC instruction in smp_* memory barriers References: <20150602000818.6668.76632.stgit@ubuntu-yegoshin> <20150602000934.6668.43645.stgit@ubuntu-yegoshin> <556D8A03.9080201@imgtec.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1551 Lines: 36 On 06/02/2015 09:15 AM, Maciej W. Rozycki wrote: > On Tue, 2 Jun 2015, James Hogan wrote: > >>> diff --git a/arch/mips/include/asm/barrier.h b/arch/mips/include/asm/barrier.h >>> index 2b8bbbcb9be0..d2a63abfc7c6 100644 >>> --- a/arch/mips/include/asm/barrier.h >>> +++ b/arch/mips/include/asm/barrier.h >>> @@ -96,9 +96,15 @@ >>> # define smp_rmb() barrier() >>> # define smp_wmb() __syncw() >>> # else >>> +# ifdef CONFIG_MIPS_LIGHTWEIGHT_SYNC >>> +# define smp_mb() __asm__ __volatile__("sync 0x10" : : :"memory") >>> +# define smp_rmb() __asm__ __volatile__("sync 0x13" : : :"memory") >>> +# define smp_wmb() __asm__ __volatile__("sync 0x4" : : :"memory") >> >> binutils appears to support the sync_mb, sync_rmb, sync_wmb aliases >> since version 2.21. Can we safely use them? > > I suggest that we don't -- we still officially support binutils 2.12 and > have other places where we even use `.word' to insert instructions current > versions of binutils properly handle. It may be worth noting in a comment > though that these encodings correspond to these operations that you named. > Surely the other MIPSr6 instructions are not supported in binutils 2.12 either. So if it is for r6, why not require modern tools, and put something user readable in here? David Daney -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/