Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752678AbbFCBG3 (ORCPT ); Tue, 2 Jun 2015 21:06:29 -0400 Received: from mail.savoirfairelinux.com ([209.172.62.77]:64584 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752538AbbFCBGU (ORCPT ); Tue, 2 Jun 2015 21:06:20 -0400 Date: Tue, 2 Jun 2015 21:06:15 -0400 (EDT) From: Vivien Didelot To: Guenter Roeck Cc: netdev , David , Florian Fainelli , Andrew Lunn , Scott Feldman , Jiri Pirko , =?utf-8?Q?J=C3=A9rome?= Oufella , linux-kernel , kernel , Chris Healy Message-ID: <1317462817.952931.1433293575321.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: <556DBCA4.10203@roeck-us.net> References: <1433208470-25338-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1433208470-25338-8-git-send-email-vivien.didelot@savoirfairelinux.com> <556DBCA4.10203@roeck-us.net> Subject: Re: [RFC 7/9] net: dsa: mv88e6352: lock CPU port from learning addresses MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.6.0_GA_1153 (ZimbraWebClient - FF38 (Linux)/8.6.0_GA_1153) Thread-Topic: mv88e6352: lock CPU port from learning addresses Thread-Index: CI+82A2MXXSzrvCUyAtniQncovrk6A== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1013 Lines: 29 Hi Guenter, On Jun 2, 2015, at 10:24 AM, Guenter Roeck linux@roeck-us.net wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: >> This commit disables SA learning and refreshing for the CPU port. >> > > Hi Vivien, > > This patch also seems to be unrelated to the rest of the series. > > Can you add an explanation why it is needed ? > > With this in place, how does the CPU port SA find its way into the fdb ? > Do we assume that it will be configured statically ? > An explanation might be useful. Without this patch, I noticed the CPU port was stealing the SA of a PC behind a switch port. this happened when the port was a bridge member, as the bridge was relaying broadcast coming from one switch port to the other switch ports in the same vlan. Thanks, -v -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/