Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752444AbbFCBMo (ORCPT ); Tue, 2 Jun 2015 21:12:44 -0400 Received: from mail.savoirfairelinux.com ([209.172.62.77]:51415 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbbFCBMe (ORCPT ); Tue, 2 Jun 2015 21:12:34 -0400 Date: Tue, 2 Jun 2015 21:12:30 -0400 (EDT) From: Vivien Didelot To: Guenter Roeck , Andrew Lunn Cc: netdev , David , Florian Fainelli , Scott Feldman , Jiri Pirko , =?utf-8?Q?J=C3=A9rome?= Oufella , linux-kernel , kernel , Chris Healy Message-ID: <1365988647.953084.1433293950168.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: <20150602145313.GU22739@lunn.ch> References: <1433208470-25338-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1433208470-25338-6-git-send-email-vivien.didelot@savoirfairelinux.com> <556DBAAA.4010408@roeck-us.net> <20150602145313.GU22739@lunn.ch> Subject: Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.6.0_GA_1153 (ZimbraWebClient - FF38 (Linux)/8.6.0_GA_1153) Thread-Topic: mv88e6352: disable mirroring Thread-Index: 4IOAXaYYQ+g1Csx8pc9NB78yhq8jiw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 34 Hi Guenter, Andrew, On Jun 2, 2015, at 10:53 AM, Andrew Lunn andrew@lunn.ch wrote: On Tue, Jun 02, 2015 at 07:16:10AM -0700, Guenter Roeck wrote: >> On 06/01/2015 06:27 PM, Vivien Didelot wrote: >> >Disable the mirroring policy in the monitor control register, since this >> >feature is not needed. >> > >> >Signed-off-by: Vivien Didelot >> >> Should this be a separate patch, unrelated to the patch set ? Indeed, this one is an unrelated patch, sorry. >> If I understand correctly, this effectively disables IGMP/MLD snooping. >> I think this warrants an explanation why that it not needed, not just >> a statement that it is not needed. > > +1 > > Especially since we might want to revisit this to implement IGMP/MLD > snooping in the bridge. The hardware should be capable of it. This is something I want to disable because I can have several times gigabit traffic on my ports. This would end up in a bottleneck on the CPU port. Am I right? Thanks, -v -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/