Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752350AbbFCBkG (ORCPT ); Tue, 2 Jun 2015 21:40:06 -0400 Received: from mail.savoirfairelinux.com ([209.172.62.77]:55314 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbbFCBjy (ORCPT ); Tue, 2 Jun 2015 21:39:54 -0400 Date: Tue, 2 Jun 2015 21:39:50 -0400 (EDT) From: Vivien Didelot To: Guenter Roeck Cc: netdev , David , Florian Fainelli , Andrew Lunn , Scott Feldman , Jiri Pirko , =?utf-8?Q?J=C3=A9rome?= Oufella , linux-kernel , kernel , Chris Healy Message-ID: <1561034247.953427.1433295590494.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: <556D522E.90607@roeck-us.net> References: <1433208470-25338-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1433208470-25338-4-git-send-email-vivien.didelot@savoirfairelinux.com> <556D522E.90607@roeck-us.net> Subject: Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.6.0_GA_1153 (ZimbraWebClient - FF38 (Linux)/8.6.0_GA_1153) Thread-Topic: mv88e6xxx: add support for VTU ops Thread-Index: GS1wBOhfS2E0itZe8b6UZkVMZ9w2zQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1114 Lines: 31 Guenter, On Jun 2, 2015, at 2:50 AM, Guenter Roeck linux@roeck-us.net wrote: > On 06/01/2015 06:27 PM, Vivien Didelot wrote: >> + /* Bringing an interface up adds it to the VLAN 0. Ignore this. */ >> + if (!vid) >> + return 0; >> + > > Me puzzled ;-). I brought this and the fid question up before. > No idea if my e-mail got lost or what happened. > > Can you explain why we don't need a configuration for vlan 0 ? Sorry for late reply. Initially, when issuing "ip link set up dev swp0", ndo_vlan_rx_add_vid was called to add the interface in the VLAN 0. 2 things happen here: * this is inconsistent with the "bridge vlan" output which doesn't seem to know about a VID 0; * VID 0 seems special for this switch: if an ingressing frame has VID 0, the tagged port will override the VID bits with the port default VID at egress. Thanks, -v -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/