Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752396AbbFCByF (ORCPT ); Tue, 2 Jun 2015 21:54:05 -0400 Received: from mga03.intel.com ([134.134.136.65]:33132 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbbFCBx5 (ORCPT ); Tue, 2 Jun 2015 21:53:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,544,1427785200"; d="scan'208";a="739833467" Message-ID: <556E5E2E.6050107@linux.intel.com> Date: Wed, 03 Jun 2015 09:53:50 +0800 From: Jiang Liu Organization: Intel User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Thomas Gleixner CC: Bjorn Helgaas , Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , Randy Dunlap , Yinghai Lu , Borislav Petkov , x86@kernel.org, Konrad Rzeszutek Wilk , Boris Ostrovsky , David Vrabel , Feng Wu , Rasmus Villemoes , Brian Gerst , Rusty Russell , Juergen Gross , Tony Luck , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Ingo Molnar , xen-devel@lists.xenproject.org Subject: Re: [Patch v3 27/36] x86, irq: Use access helper irq_data_get_affinity_mask() References: <1433145945-789-1-git-send-email-jiang.liu@linux.intel.com> <1433145945-789-28-git-send-email-jiang.liu@linux.intel.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 36 On 2015/6/3 3:19, Thomas Gleixner wrote: > On Mon, 1 Jun 2015, Jiang Liu wrote: > >> diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c >> index 9b62f690b0ff..dfa3a5f5b3d3 100644 >> --- a/arch/x86/kernel/apic/vector.c >> +++ b/arch/x86/kernel/apic/vector.c >> @@ -494,9 +494,8 @@ static int apic_set_affinity(struct irq_data *irq_data, >> >> err = assign_irq_vector(irq, data, dest); >> if (err) { >> - struct irq_data *top = irq_get_irq_data(irq); >> - >> - if (assign_irq_vector(irq, data, top->affinity)) >> + if (assign_irq_vector(irq, data, >> + irq_data_get_affinity_mask(irq_data))) > > Does this patch work w/o moving the affinity mask to common data? I > doubt so, as you remove the retrieval of 'top'. Hi Thomas, This piece of code should be moved into [31/36], otherwise it will break bisecting. I will redo patch this and [31/36] to support bisecting. Thanks! Gerry > > Thanks, > > tglx > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/