Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753266AbbFCC1x (ORCPT ); Tue, 2 Jun 2015 22:27:53 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:40567 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbbFCC1q (ORCPT ); Tue, 2 Jun 2015 22:27:46 -0400 Date: Tue, 2 Jun 2015 19:27:42 -0700 From: Guenter Roeck To: Vivien Didelot Cc: Andrew Lunn , netdev , David , Florian Fainelli , Scott Feldman , Jiri Pirko , =?iso-8859-1?Q?J=E9rome?= Oufella , linux-kernel , kernel , Chris Healy Subject: Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring Message-ID: <20150603022742.GC932@roeck-us.net> References: <1433208470-25338-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1433208470-25338-6-git-send-email-vivien.didelot@savoirfairelinux.com> <556DBAAA.4010408@roeck-us.net> <20150602145313.GU22739@lunn.ch> <1365988647.953084.1433293950168.JavaMail.zimbra@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1365988647.953084.1433293950168.JavaMail.zimbra@savoirfairelinux.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1622 Lines: 40 On Tue, Jun 02, 2015 at 09:12:30PM -0400, Vivien Didelot wrote: > Hi Guenter, Andrew, > > On Jun 2, 2015, at 10:53 AM, Andrew Lunn andrew@lunn.ch wrote: > On Tue, Jun 02, 2015 at 07:16:10AM -0700, Guenter Roeck wrote: > >> On 06/01/2015 06:27 PM, Vivien Didelot wrote: > >> >Disable the mirroring policy in the monitor control register, since this > >> >feature is not needed. > >> > > >> >Signed-off-by: Vivien Didelot > >> > >> Should this be a separate patch, unrelated to the patch set ? > > Indeed, this one is an unrelated patch, sorry. > > >> If I understand correctly, this effectively disables IGMP/MLD snooping. > >> I think this warrants an explanation why that it not needed, not just > >> a statement that it is not needed. > > > > +1 > > > > Especially since we might want to revisit this to implement IGMP/MLD > > snooping in the bridge. The hardware should be capable of it. > > This is something I want to disable because I can have several times > gigabit traffic on my ports. This would end up in a bottleneck on the > CPU port. Am I right? > Not really. That should not be that much traffic. Besides, IGMP/MLD snooping still needs to be enabled separately, as well as egress monitoring. I don't think this has any impact on the traffic to the CPU port unless other configuration bits are set as well. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/