Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbbFCE7V (ORCPT ); Wed, 3 Jun 2015 00:59:21 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:47235 "EHLO e23smtp09.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbbFCE7O (ORCPT ); Wed, 3 Jun 2015 00:59:14 -0400 In-Reply-To: <1433307179-17020-1-git-send-email-david@gibson.dropbear.id.au> References: <1433307179-17020-1-git-send-email-david@gibson.dropbear.id.au> Subject: Re: [PATCH] powerpc/eeh: Fix trivial error in eeh_restore_dev_state() X-KeepSent: 4582BD1A:5370252A-CA257E59:001B1345; type=4; name=$KeepSent To: David Gibson Cc: benh@kernel.crashing.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, paulus@samba.org, gwshan@linux.vnet.ibm.com X-Mailer: IBM Notes Release 9.0.1 October 14, 2013 Message-ID: From: Guo Wen Shan Date: Wed, 3 Jun 2015 14:58:09 +1000 X-MIMETrack: Serialize by Router on d23ml002/23/M/IBM(Release 8.5.3FP6HF1222 | December 16, 2014) at 03/06/2015 14:58:34 MIME-Version: 1.0 Content-type: text/plain; charset=US-ASCII X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15060304-0033-0000-0000-0000019915FF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1806 Lines: 59 David Gibson wrote on 03/06/2015 14:52:59: > From: David Gibson > To: Guo Wen Shan/Australia/IBM@IBMAU, mpe@ellerman.id.au > Cc: benh@kernel.crashing.org, paulus@samba.org, linuxppc- > dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, David Gibson > > Date: 03/06/2015 14:53 > Subject: [PATCH] powerpc/eeh: Fix trivial error in eeh_restore_dev_state () > > Commit 28158cd "powerpc/eeh: Enhance pcibios_set_pcie_reset_state()" > introduced a fix for a problem where certain configurations could lead to > pci_reset_function() destroying the state of PCI devices other than the one > specified. > > Unfortunately, the fix has a trivial bug - it calls pci_save_state() again, > when it should be calling pci_restore_state(). This corrects the problem. > > Cc: Gavin Shan > Signed-off-by: David Gibson Acked-by: Gavin Shan Thanks, Gavin > --- > arch/powerpc/kernel/eeh.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c > index 9ee61d1..ece4181 100644 > --- a/arch/powerpc/kernel/eeh.c > +++ b/arch/powerpc/kernel/eeh.c > @@ -719,7 +719,7 @@ static void *eeh_restore_dev_state(void *data, > void *userdata) > > /* The caller should restore state for the specified device */ > if (pdev != dev) > - pci_save_state(pdev); > + pci_restore_state(pdev); > > return NULL; > } > -- > 2.4.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/