Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753121AbbFCGPx (ORCPT ); Wed, 3 Jun 2015 02:15:53 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:34118 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343AbbFCGPp (ORCPT ); Wed, 3 Jun 2015 02:15:45 -0400 Date: Wed, 3 Jun 2015 11:45:37 +0530 From: Sudip Mukherjee To: Andrew Andrianov Cc: Greg Kroah-Hartman , pebolle@tiscali.nl, Arve =?utf-8?B?SGrvv71ubmV277+9Zw==?= , Riley Andrews , Chen Gang , Fabian Frederick , Android Kernel Team , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] staging: ion: Add generic ion-physmem driver Message-ID: <20150603061537.GC4936@sudip-PC> References: <1433260840-16723-1-git-send-email-andrew@ncrmnt.org> <1433260840-16723-2-git-send-email-andrew@ncrmnt.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433260840-16723-2-git-send-email-andrew@ncrmnt.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1421 Lines: 39 On Tue, Jun 02, 2015 at 07:00:39PM +0300, Andrew Andrianov wrote: > From: Andrew 'Necromant' Andrianov > > This patch adds a generic ion driver that allows > ion heaps to be added via devicetree. It provides > a simple and generic way to feed physical memory regions > to ion without writing a custom driver, e.g. > > ion_sram: ion@0x00100000 { > compatible = "ion,physmem"; > reg = <0x00100000 0x40000>; > reg-names = "memory"; > ion-heap-id = <1>; > ion-heap-type = ; > ion-heap-align = <0x10>; > ion-heap-name = "SRAM"; > }; > > Signed-off-by: Andrew Andrianov Your From: name and Signed-off-by: name is not matching. But why you are using this extra From: line? you email header From: is same as your Signed-off-by. And since you are adding new files it would be better if you can fix few checkpatch warnings it has. like: CHECK: Prefer kzalloc(sizeof(*ipdev)...) over kzalloc(sizeof(struct physmem_ion_dev)...) CHECK: Alignment should match open parenthesis CHECK: No space is necessary after a cast CHECK: Please don't use multiple blank lines regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/