Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753382AbbFCH1B (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Jun 2015 03:27:01 -0400
Received: from mail-pd0-f171.google.com ([209.85.192.171]:34752 "EHLO
	mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751768AbbFCH0x (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Jun 2015 03:26:53 -0400
Date: Wed, 3 Jun 2015 12:56:42 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Cc: gregkh@linuxfoundation.org, joe@perches.com, devel@driverdev.osuosl.org,
        dan.carpenter@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/11] staging: rtl8192e: Remove dead code:
 dig_t::dbg_mode
Message-ID: <20150603072642.GA6897@sudip-PC>
References: <1433278095-13988-1-git-send-email-mateusz.kulikowski@gmail.com>
 <1433278095-13988-8-git-send-email-mateusz.kulikowski@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1433278095-13988-8-git-send-email-mateusz.kulikowski@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1431
Lines: 34

On Tue, Jun 02, 2015 at 10:48:11PM +0200, Mateusz Kulikowski wrote:
> dig_t::dbg_mode is initialized to one value and checked only once in code.
> This patch throws it away, and deletes always-true condition.
> 
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtl8192e/rtl_dm.c |  5 +----
>  drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 24 ------------------------
>  2 files changed, 1 insertion(+), 28 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> index d869629..95a7c8e 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
<snip>
> @@ -1949,7 +1947,6 @@ static void dm_init_rxpath_selection(struct net_device *dev)
>  		DM_RxPathSelTable.cck_method = CCK_Rx_Version_2;
>  	else
>  		DM_RxPathSelTable.cck_method = CCK_Rx_Version_1;
> -	DM_RxPathSelTable.DbgMode = DM_DBG_OFF;
so now DM_RxPathSelTable.DbgMode is not initialized, but at line 1992 we have

if (!DM_RxPathSelTable.DbgMode)
	DM_RxPathSelTable.rf_rssi[i] = priv->stats.rx_rssi_percentage[i];

am i missing something here?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/