Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753814AbbFCIgy (ORCPT ); Wed, 3 Jun 2015 04:36:54 -0400 Received: from mx5.ptsecurity.com ([45.58.112.35]:21734 "EHLO mx5.ptsecurity.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753702AbbFCIgj (ORCPT ); Wed, 3 Jun 2015 04:36:39 -0400 Message-ID: <556EBCC3.4070500@ptsecurity.com> Date: Wed, 3 Jun 2015 11:37:23 +0300 From: Alexander Popov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ingo Molnar CC: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andrey Ryabinin , Andrey Konovalov , Andrew Morton , Kees Cook , "Peter Zijlstra (Intel)" , Andy Lutomirski , Alexander Kuleshov , "Borislav Petkov" , Denys Vlasenko , , Subject: Re: [PATCH v4 1/1] x86_64: fix KASan shadow region page tables References: <1433249837-7096-1-git-send-email-alpopov@ptsecurity.com> <20150603074427.GA1598@gmail.com> In-Reply-To: <20150603074427.GA1598@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DC1-CAS-02.ptsecurity.ru (10.0.52.115) To DC1-MBX-02.ptsecurity.ru (10.0.52.117) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 870 Lines: 25 On 03.06.2015 10:44, Ingo Molnar wrote: > > * Alexander Popov wrote: >> + kasan_early_init(); >> + kasan_map_early_shadow(early_level4_pgt); > > So why isn't kasan_map_early_shadow() called in kasan_early_init()? > > High level x86 init code should not be polluted with too many low level details. Hello, Ingo. kasan_map_early_shadow() is called twice in x86_64_start_kernel(): once for early_level4_pgt and then later for init_level4_pgt. I've decided to introduce separate kasan_early_init() to avoid big changes which can bring consequences that I don't understand. Best regards, Alexander -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/