Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753950AbbFCIqw (ORCPT ); Wed, 3 Jun 2015 04:46:52 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56053 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbbFCIqo (ORCPT ); Wed, 3 Jun 2015 04:46:44 -0400 Date: Wed, 3 Jun 2015 10:46:31 +0200 (CEST) From: Jiri Kosina To: Andrew Duggan cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires , Mika Westerberg , Benson Leung Subject: Re: [PATCH] HID: i2c-hid: Do not set the ACPI companion field in the HID device In-Reply-To: <1433281580-8319-1-git-send-email-aduggan@synaptics.com> Message-ID: References: <1433281580-8319-1-git-send-email-aduggan@synaptics.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 21 On Tue, 2 Jun 2015, Andrew Duggan wrote: > The HID device does not need to know about the ACPI device associated with > the underlying i2c device. Setting the ACPI companion field in the HID device > also has the side effect of causing HID to be set as wake capable, since > acpi_bind_one uses's the companion ACPI device's wakeup flags to set the > device as wake capable. Which results in power/wakeup files in sysfs for > the HID device which do not do anything. > > Signed-off-by: Andrew Duggan Applied to for-4.2/i2c-hid. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/