Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753569AbbFCIyN (ORCPT ); Wed, 3 Jun 2015 04:54:13 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:38549 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752756AbbFCIyH (ORCPT ); Wed, 3 Jun 2015 04:54:07 -0400 From: Wang Nan To: , , CC: , , , Subject: [PATCH tip] perf tools: Fix a compiling problem Date: Wed, 3 Jun 2015 08:50:26 +0000 Message-ID: <1433321426-170133-1-git-send-email-wangnan0@huawei.com> X-Mailer: git-send-email 1.8.3.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.107.197.200] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1177 Lines: 31 Commit 4bb11d012ab248d0e383008d725be0d26a74fac2 ("perf tools: Add dso__data_get/put_fd()") has a problem: it uses a undefined variable 'dso' in find_proc_info(), which should be 'map->dso'. The buggy code piece is not compiled if NO_LIBUNWIND_DEBUG_FRAME is not set. Signed-off-by: Wang Nan --- tools/perf/util/unwind-libunwind.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c index f079b63..4c00507 100644 --- a/tools/perf/util/unwind-libunwind.c +++ b/tools/perf/util/unwind-libunwind.c @@ -360,7 +360,7 @@ find_proc_info(unw_addr_space_t as, unw_word_t ip, unw_proc_info_t *pi, unw_word_t base = is_exec ? 0 : map->start; if (fd >= 0) - dso__data_put_fd(dso); + dso__data_put_fd(map->dso); memset(&di, 0, sizeof(di)); if (dwarf_find_debug_frame(0, &di, ip, base, map->dso->name, -- 1.8.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/