Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753695AbbFCJZE (ORCPT ); Wed, 3 Jun 2015 05:25:04 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:35775 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752047AbbFCJYz (ORCPT ); Wed, 3 Jun 2015 05:24:55 -0400 Date: Wed, 3 Jun 2015 11:24:51 +0200 From: Ingo Molnar To: Matthew Garrett Cc: Matthew Garrett , hpa@zytor.com, yinghai@kernel.org, x86@kernel.org, mingo@redhat.com, tglx@linutronix.de, Linux Kernel Mailing List Subject: Re: [PATCH V2] x86: Allow built-in command line to work in early kernel init Message-ID: <20150603092450.GB13837@gmail.com> References: <1432076995-11685-1-git-send-email-mjg59@coreos.com> <20150520074231.GA25959@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1542 Lines: 45 * Matthew Garrett wrote: > >> + while (c) { > >> + set_fs(new_cmdline_ptr >> 4); > >> + wrfs8(c, nptr++); > >> + set_fs(cmdline_ptr >> 4); > >> + c = rdfs8(cptr++); > >> + } > >> + set_fs(new_cmdline_ptr >> 4); > >> + wrfs8(' ', nptr++); > >> + } > > > > So here we copy from 'cptr' to 'nptr'? Not very well named variables, > > at minimum. > > I have the choice between preserving existing style or nice names. > I'm happy to pick either. So my high level concerns (and conditions) are the following: We should first do cleanups and reorganization so that the feature addition (allowing EFI to parse certain options early on) you are implementing becomes obvious and simple. I.e. we need to first prove it's all maintainable and readable, and then only can we add a feature with such a signature: 13 files changed, 236 insertions(+), 43 deletions(-) I'd also expect that a good chunk of that linecount increase would disappear after a proper set of reorganization, because all that duplication would disappear mostly. It's all pretty non-trivial, so it has to be finegrained, perfectly bisectable, etc. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/