Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753463AbbFCJaX (ORCPT ); Wed, 3 Jun 2015 05:30:23 -0400 Received: from mga02.intel.com ([134.134.136.20]:38373 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774AbbFCJaQ (ORCPT ); Wed, 3 Jun 2015 05:30:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,546,1427785200"; d="scan'208";a="736214049" Message-ID: <1433323812.26331.43.camel@linux.intel.com> Subject: Re: [PATCH v9 1/3] x86/setup: introduce setup_bultin_cmdline From: Andy Shevchenko To: Alexander Kuleshov Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , LKML , Greg Kroah-Hartman , Borislav Petkov , Mark Rustad , Yinghai Lu Date: Wed, 03 Jun 2015 12:30:12 +0300 In-Reply-To: <1433318116-7061-1-git-send-email-kuleshovmail@gmail.com> References: <1433318072-5611-1-git-send-email-kuleshovmail@gmail.com> <1433318116-7061-1-git-send-email-kuleshovmail@gmail.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1398 Lines: 45 On Wed, 2015-06-03 at 13:55 +0600, Alexander Kuleshov wrote: > This patch introduces the setup_builtin_cmdline function which appends or > overrides boot_command_line with the builtin_cmdline if CONFIG_CMDLINE_BOOL > is set. > Previously this functional was in the setup_arch, but we need to move > it for getting actual command line as early as possible in the > arch/x86/kernel/head{32,64}.c for the earlyprintk setup. [] > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -733,7 +733,7 @@ static void __init trim_snb_memory(void) > * already been reserved. > */ > memblock_reserve(0, 1<<20); > - > + > for (i = 0; i < ARRAY_SIZE(bad_pages); i++) { > if (memblock_reserve(bad_pages[i], PAGE_SIZE)) > printk(KERN_WARNING "failed to reserve 0x%08lx\n", > @@ -825,7 +825,7 @@ static void __init trim_low_memory_range(void) > { > memblock_reserve(0, ALIGN(reserve_low, PAGE_SIZE)); > } > - > + > /* > * Dump out kernel offset information on panic. > */ You again mixed things in one patch. Style thing if you wish shall go separately. -- Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/