Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752921AbbFCK1E (ORCPT ); Wed, 3 Jun 2015 06:27:04 -0400 Received: from mga11.intel.com ([192.55.52.93]:7085 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160AbbFCK0x convert rfc822-to-8bit (ORCPT ); Wed, 3 Jun 2015 06:26:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,546,1427785200"; d="scan'208";a="740054435" From: "Tirdea, Irina" To: Antonio Ospite CC: Dmitry Torokhov , Bastien Nocera , "linux-input@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 2/9] input: goodix: fix variable length array warning Thread-Topic: [PATCH 2/9] input: goodix: fix variable length array warning Thread-Index: AQHQmV8htopf2amRKkucsrvfvD6ZK52amtFA Date: Wed, 3 Jun 2015 10:26:47 +0000 Deferred-Delivery: Wed, 3 Jun 2015 10:26:00 +0000 Message-ID: <1F3AC3675D538145B1661F571FE1805F19A78DD0@irsmsx105.ger.corp.intel.com> References: <1432817265-23891-1-git-send-email-irina.tirdea@intel.com> <1432817265-23891-3-git-send-email-irina.tirdea@intel.com> <20150528175753.1f85723b5b880ecf02fd4a79@ao2.it> In-Reply-To: <20150528175753.1f85723b5b880ecf02fd4a79@ao2.it> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2475 Lines: 77 > -----Original Message----- > From: Antonio Ospite [mailto:ao2@ao2.it] > Sent: 28 May, 2015 18:58 > To: Tirdea, Irina > Cc: Dmitry Torokhov; Bastien Nocera; linux-input@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 2/9] input: goodix: fix variable length array warning > > On Thu, 28 May 2015 15:47:38 +0300 > Irina Tirdea wrote: > > > Fix sparse warning: > > drivers/input/touchscreen/goodix.c:182:26: warning: > > Variable length array is used. > > > > Replace the variable length array with fixed length. > > > > Signed-off-by: Irina Tirdea > > --- > > drivers/input/touchscreen/goodix.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c > > index c2e785c..dac1b3c 100644 > > --- a/drivers/input/touchscreen/goodix.c > > +++ b/drivers/input/touchscreen/goodix.c > > @@ -147,7 +147,7 @@ static void goodix_ts_report_touch(struct goodix_ts_data *ts, u8 *coor_data) > > */ > > static void goodix_process_events(struct goodix_ts_data *ts) > > { > > - u8 point_data[1 + GOODIX_CONTACT_SIZE * ts->max_touch_num]; > > + u8 point_data[1 + GOODIX_CONTACT_SIZE * GOODIX_MAX_CONTACTS]; > > Hi, > Hi Antonio, > this fixes the warning from sparse, but also changes the semantics of > the code: ts->max_touch_num is less that GOODIX_MAX_CONTACTS for 5 > touches devices and in this case we'll end up using more memory than is > necessary. > I wasn't sure if it is better to save the 5 bytes or fix the warning, so I sent this to get some more input. Thanks for the feedback, I will drop this patch. Thanks, Irina > Thanks, > Antonio > > > int touch_num; > > int i; > > > > -- > > 1.9.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-input" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > Antonio Ospite > http://ao2.it > > A: Because it messes up the order in which people normally read text. > See http://en.wikipedia.org/wiki/Posting_style > Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/