Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754059AbbFCKa7 (ORCPT ); Wed, 3 Jun 2015 06:30:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50388 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbbFCKav (ORCPT ); Wed, 3 Jun 2015 06:30:51 -0400 Date: Wed, 3 Jun 2015 12:30:45 +0200 From: Jiri Olsa To: Sukadev Bhattiprolu Cc: mingo@redhat.com, ak@linux.intel.com, Michael Ellerman , Arnaldo Carvalho de Melo , namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 02/14] perf, tools, jevents: Program to convert JSON file to C style file Message-ID: <20150603103045.GC1828@krava.redhat.com> References: <1433265135-20426-1-git-send-email-sukadev@linux.vnet.ibm.com> <1433265135-20426-3-git-send-email-sukadev@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433265135-20426-3-git-send-email-sukadev@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1353 Lines: 60 On Tue, Jun 02, 2015 at 10:12:02AM -0700, Sukadev Bhattiprolu wrote: SNIP > + > +static char *file_name_to_table_name(char *fname) > +{ > + unsigned int i, j; > + int c; > + int n = 1024; /* use max variable length? */ I think this should be at least PATH_MAX, or you might actually use asprintf and have all below done within one line or so jirka > + char *tblname; > + char *p; > + > + tblname = malloc(n); > + if (!tblname) > + return NULL; > + > + p = basename(fname); > + > + memset(tblname, 0, n); > + > + /* Ensure table name starts with an alphabetic char */ > + strcpy(tblname, "pme_"); > + > + n = strlen(fname) + strlen(tblname); > + n = min(1024, n); > + > + for (i = 0, j = strlen(tblname); i < strlen(fname); i++, j++) { > + c = p[i]; > + if (isalnum(c) || c == '_') > + tblname[j] = c; > + else if (c == '-') > + tblname[j] = '_'; > + else if (c == '.') { > + tblname[j] = '\0'; > + break; > + } else { > + pr_err("%s: Invalid character '%c' in file name %s\n", > + prog, c, p); > + free(tblname); > + return NULL; > + } > + } > + > + return tblname; > +} SNIP -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/