Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754121AbbFCKbU (ORCPT ); Wed, 3 Jun 2015 06:31:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45599 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754107AbbFCKbO (ORCPT ); Wed, 3 Jun 2015 06:31:14 -0400 Date: Wed, 3 Jun 2015 12:31:07 +0200 From: Jiri Olsa To: Sukadev Bhattiprolu Cc: mingo@redhat.com, ak@linux.intel.com, Michael Ellerman , Arnaldo Carvalho de Melo , namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 03/14] perf, tools: Use pmu_events_map table to create event aliases Message-ID: <20150603103107.GE1828@krava.redhat.com> References: <1433265135-20426-1-git-send-email-sukadev@linux.vnet.ibm.com> <1433265135-20426-4-git-send-email-sukadev@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433265135-20426-4-git-send-email-sukadev@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1320 Lines: 33 On Tue, Jun 02, 2015 at 10:12:03AM -0700, Sukadev Bhattiprolu wrote: > At run time, (i.e when perf is starting up), locate the specific events > table for the current CPU and create event aliases for each of the events. > > Use these aliases to parse user's specified perf event. > > Signed-off-by: Sukadev Bhattiprolu > > Changelog[v3] > [Jiri Olsa] Fix a memory leak with cpuid. > > Changelog[v2] > [Andi Kleen] Replace the pmu_events_map->vfm field with a simple > generic "cpuid" string and use that string to find the > matching mapfile entry. > --- > tools/perf/arch/powerpc/util/header.c | 11 ++++ > tools/perf/util/header.h | 3 +- > tools/perf/util/pmu.c | 104 ++++++++++++++++++++++++++++----- > 3 files changed, 104 insertions(+), 14 deletions(-) I think this patch is doing too much, it should be split into 3 pieces: - introduce get_cpuid_str for powerpc - introducing __perf_pmu__new_alias/perf_pmu__new_alias functions split - adding pmu_add_cpu_aliases functionality jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/