Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754318AbbFCKcW (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Jun 2015 06:32:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56777 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754276AbbFCKcJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Jun 2015 06:32:09 -0400
Date: Wed, 3 Jun 2015 12:32:04 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: mingo@redhat.com, ak@linux.intel.com,
        Michael Ellerman <mpe@ellerman.id.au>,
        Arnaldo Carvalho de Melo <acme@kernel.org>, namhyung@kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        Robert Richter <rric@kernel.org>
Subject: Re: [PATCH v13 04/14] perf, tools: Allow events with dot
Message-ID: <20150603103204.GI1828@krava.redhat.com>
References: <1433265135-20426-1-git-send-email-sukadev@linux.vnet.ibm.com>
 <1433265135-20426-5-git-send-email-sukadev@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1433265135-20426-5-git-send-email-sukadev@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2001
Lines: 62

On Tue, Jun 02, 2015 at 10:12:04AM -0700, Sukadev Bhattiprolu wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> The Intel events use a dot to separate event name and unit mask.
> Allow dot in names in the scanner, and remove special handling
> of dot as EOF. Also remove the hack in jevents to replace dot
> with underscore. This way dotted events can be specified
> directly by the user.
> 
> I'm not fully sure this change to the scanner is correct
> (what was the dot special case good for?), but I haven't
> found anything that breaks with it so far at least.

can't see anything either

Robert,
does it ring a bell? seems like you introduced it ;-)

thanks,
jirka


> 
> V2: Add the dot to name too, to handle events outside cpu//
> Acked-by: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> ---
>  tools/perf/util/parse-events.l |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
> index 09e738f..13cef3c 100644
> --- a/tools/perf/util/parse-events.l
> +++ b/tools/perf/util/parse-events.l
> @@ -119,8 +119,8 @@ event		[^,{}/]+
>  num_dec		[0-9]+
>  num_hex		0x[a-fA-F0-9]+
>  num_raw_hex	[a-fA-F0-9]+
> -name		[a-zA-Z_*?][a-zA-Z0-9_*?]*
> -name_minus	[a-zA-Z_*?][a-zA-Z0-9\-_*?]*
> +name		[a-zA-Z_*?][a-zA-Z0-9_*?.]*
> +name_minus	[a-zA-Z_*?][a-zA-Z0-9\-_*?.]*
>  /* If you add a modifier you need to update check_modifier() */
>  modifier_event	[ukhpGHSDI]+
>  modifier_bp	[rwx]{1,3}
> @@ -165,7 +165,6 @@ modifier_bp	[rwx]{1,3}
>  			return PE_EVENT_NAME;
>  		}
>  
> -.		|
>  <<EOF>>		{
>  			BEGIN(INITIAL);
>  			REWIND(0);
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/