Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754406AbbFCKci (ORCPT ); Wed, 3 Jun 2015 06:32:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58307 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754324AbbFCKcY (ORCPT ); Wed, 3 Jun 2015 06:32:24 -0400 Date: Wed, 3 Jun 2015 12:32:17 +0200 From: Jiri Olsa To: Sukadev Bhattiprolu Cc: mingo@redhat.com, ak@linux.intel.com, Michael Ellerman , Arnaldo Carvalho de Melo , namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 11/14] perf, tools: Support long descriptions with perf list -v Message-ID: <20150603103217.GJ1828@krava.redhat.com> References: <1433265135-20426-1-git-send-email-sukadev@linux.vnet.ibm.com> <1433265135-20426-12-git-send-email-sukadev@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433265135-20426-12-git-send-email-sukadev@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1791 Lines: 48 On Tue, Jun 02, 2015 at 10:12:11AM -0700, Sukadev Bhattiprolu wrote: > From: Andi Kleen > > Previously we were dropping the useful longer descriptions that some > events have in the event list completely. This patch makes them appear with > perf list. > > Old perf list: > > baclears: > baclears.all > [Counts the number of baclears] > > vs new: > > perf list -v: > ... > baclears: > baclears.all > [The BACLEARS event counts the number of times the front end is resteered, mainly when > the Branch Prediction Unit cannot provide a correct prediction and this is corrected > by the Branch Address Calculator at the front end. The BACLEARS.ANY event counts the > number of baclears for any type of branch] > > Signed-off-by: Andi Kleen > Signed-off-by: Sukadev Bhattiprolu > --- > tools/perf/builtin-list.c | 9 ++++++--- > tools/perf/pmu-events/jevents.c | 29 ++++++++++++++++++++--------- > tools/perf/pmu-events/jevents.h | 2 +- > tools/perf/pmu-events/pmu-events.h | 1 + > tools/perf/util/parse-events.c | 4 ++-- > tools/perf/util/parse-events.h | 2 +- > tools/perf/util/pmu.c | 17 ++++++++++++----- > tools/perf/util/pmu.h | 4 +++- > 8 files changed, 46 insertions(+), 22 deletions(-) I think this change should be split into: - jevents update of parsing out PublicDescription tag - alias support for long_desc - perf list update jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/