Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754500AbbFCKdK (ORCPT ); Wed, 3 Jun 2015 06:33:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50766 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754465AbbFCKc7 (ORCPT ); Wed, 3 Jun 2015 06:32:59 -0400 Date: Wed, 3 Jun 2015 12:32:53 +0200 From: Jiri Olsa To: Sukadev Bhattiprolu Cc: mingo@redhat.com, ak@linux.intel.com, Michael Ellerman , Arnaldo Carvalho de Melo , namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 02/14] perf, tools, jevents: Program to convert JSON file to C style file Message-ID: <20150603103253.GM1828@krava.redhat.com> References: <1433265135-20426-1-git-send-email-sukadev@linux.vnet.ibm.com> <1433265135-20426-3-git-send-email-sukadev@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1433265135-20426-3-git-send-email-sukadev@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1280 Lines: 44 On Tue, Jun 02, 2015 at 10:12:02AM -0700, Sukadev Bhattiprolu wrote: SNIP > + > +static int process_mapfile(FILE *outfp, char *fpath) > +{ > + int n = 16384; > + FILE *mapfp; > + char *save; > + char *line, *p; > + int line_num; > + char *tblname; > + > + pr_info("%s: Processing mapfile %s\n", prog, fpath); SNIP > + > + cpuid = strtok_r(p, ",", &save); > + version = strtok_r(NULL, ",", &save); > + fname = strtok_r(NULL, ",", &save); > + type = strtok_r(NULL, ",", &save); > + > + tblname = file_name_to_table_name(fname); > + fprintf(outfp, "{\n"); > + fprintf(outfp, "\t.cpuid = \"%s\",\n", cpuid); > + fprintf(outfp, "\t.version = \"%s\",\n", version); > + fprintf(outfp, "\t.type = \"%s\",\n", type); got build failure for make DEBUG=1: CC pmu-events/jevents.o pmu-events/jevents.c: In function ‘process_mapfile’: pmu-events/jevents.c:498:10: error: ‘save’ may be used uninitialized in this function [-Werror=maybe-uninitialized] fprintf(outfp, "\t.type = \"%s\",\n", type); ^ jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/