Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754388AbbFCLhE (ORCPT ); Wed, 3 Jun 2015 07:37:04 -0400 Received: from blu004-omc1s36.hotmail.com ([65.55.116.47]:58279 "EHLO BLU004-OMC1S36.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752548AbbFCLgz (ORCPT ); Wed, 3 Jun 2015 07:36:55 -0400 X-TMN: [3+lQODjSi2SdIeA4jFZBZT+JSzSG7afP] X-Originating-Email: [xili_gchen_5257@hotmail.com] Message-ID: Date: Wed, 3 Jun 2015 19:36:47 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Jesper Nilsson CC: Jesper Nilsson , Greg Kroah-Hartman , linux-cris-kernel , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] cris: Wire up missing syscalls References: <20150603102003.GB26605@axis.com> In-Reply-To: <20150603102003.GB26605@axis.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 03 Jun 2015 11:36:52.0914 (UTC) FILETIME=[965D9920:01D09DF1] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5000 Lines: 137 On 06/03/2015 06:20 PM, Jesper Nilsson wrote: > > On Wed, May 06, 2015 at 03:48:12PM +0200, Chen Gang wrote: >> The related warnings: >> >> CALL scripts/checksyscalls.sh >> :1229:2: warning: #warning syscall sched_setattr not implemented [-Wcpp] >> :1232:2: warning: #warning syscall sched_getattr not implemented [-Wcpp] >> :1235:2: warning: #warning syscall renameat2 not implemented [-Wcpp] >> :1238:2: warning: #warning syscall seccomp not implemented [-Wcpp] >> :1241:2: warning: #warning syscall getrandom not implemented [-Wcpp] >> :1244:2: warning: #warning syscall memfd_create not implemented [-Wcpp] >> :1247:2: warning: #warning syscall bpf not implemented [-Wcpp] >> :1250:2: warning: #warning syscall execveat not implemented [-Wcpp] >> >> Signed-off-by: Chen Gang > > Thanks and applied, sorry for the long delay, I had to rewrite the patch a bit > since the v10 and v32 does not have the same standard in prefixing underscores. > Also, to be safe I also bumped the NR_syscalls as below. > Oh, it doesn't matter, everyone's time resources are expensive, so I should/can understand your delay response. I also delayed many things, e.g. I planed to wire up all syscalls for all archs within 2015-05-31, but I delayed (2 another archs: frv and m32r are still left, I shall try to send patches for them, next). - One main excuse is I have to devote much free time resources on qemu, which I have delayed too much to bear (now, I am still trying). - The other reason is frv upstream compiler can be built, but can not work at all, I have to analyse it firstly. Sorry for my carelessness: use "_sys*", and keep original NR_syscalls no touch. And also 3 additional things I guess we may need a look: - For v10, need we also use "sys*" instead of "_sys*"? - Most archs do not implement seccomp and bpf, which can pass building, but will return -ENOSYS during running. Need we left them still as warnings? (I guess, it depends on the maintainer's taste). - In the latest next tree, it also add additional userfaultfd syscall, need we add it, too? Thanks. > --- > arch/cris/arch-v10/kernel/entry.S | 8 ++++++++ > arch/cris/arch-v32/kernel/entry.S | 8 ++++++++ > arch/cris/include/asm/unistd.h | 2 +- > arch/cris/include/uapi/asm/unistd.h | 8 ++++++++ > 4 files changed, 25 insertions(+), 1 deletion(-) > > diff --git a/arch/cris/arch-v10/kernel/entry.S b/arch/cris/arch-v10/kernel/entry.S > index 81570fc..d94c520 100644 > --- a/arch/cris/arch-v10/kernel/entry.S > +++ b/arch/cris/arch-v10/kernel/entry.S > @@ -955,6 +955,14 @@ sys_call_table: > .long sys_process_vm_writev > .long sys_kcmp /* 350 */ > .long sys_finit_module > + .long _sys_sched_setattr > + .long _sys_sched_getattr > + .long _sys_renameat2 > + .long _sys_seccomp /* 355 */ > + .long _sys_getrandom > + .long _sys_memfd_create > + .long _sys_bpf > + .long _sys_execveat > > /* > * NOTE!! This doesn't have to be exact - we just have > diff --git a/arch/cris/arch-v32/kernel/entry.S b/arch/cris/arch-v32/kernel/entry.S > index 026a0b2..1c5595a 100644 > --- a/arch/cris/arch-v32/kernel/entry.S > +++ b/arch/cris/arch-v32/kernel/entry.S > @@ -875,6 +875,14 @@ sys_call_table: > .long sys_process_vm_writev > .long sys_kcmp /* 350 */ > .long sys_finit_module > + .long sys_sched_setattr > + .long sys_sched_getattr > + .long sys_renameat2 > + .long sys_seccomp /* 355 */ > + .long sys_getrandom > + .long sys_memfd_create > + .long sys_bpf > + .long sys_execveat > > /* > * NOTE!! This doesn't have to be exact - we just have > diff --git a/arch/cris/include/asm/unistd.h b/arch/cris/include/asm/unistd.h > index 0f40fed..9c23535 100644 > --- a/arch/cris/include/asm/unistd.h > +++ b/arch/cris/include/asm/unistd.h > @@ -4,7 +4,7 @@ > #include > > > -#define NR_syscalls 360 > +#define NR_syscalls 365 > > #include > > diff --git a/arch/cris/include/uapi/asm/unistd.h b/arch/cris/include/uapi/asm/unistd.h > index f3287fa..062b648 100644 > --- a/arch/cris/include/uapi/asm/unistd.h > +++ b/arch/cris/include/uapi/asm/unistd.h > @@ -356,5 +356,13 @@ > #define __NR_process_vm_writev 349 > #define __NR_kcmp 350 > #define __NR_finit_module 351 > +#define __NR_sched_setattr 352 > +#define __NR_sched_getattr 353 > +#define __NR_renameat2 354 > +#define __NR_seccomp 355 > +#define __NR_getrandom 356 > +#define __NR_memfd_create 357 > +#define __NR_bpf 358 > +#define __NR_execveat 359 > > #endif /* _UAPI_ASM_CRIS_UNISTD_H_ */ > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/