Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758363AbbFCMbW (ORCPT ); Wed, 3 Jun 2015 08:31:22 -0400 Received: from mail-oi0-f51.google.com ([209.85.218.51]:33923 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753487AbbFCMbO (ORCPT ); Wed, 3 Jun 2015 08:31:14 -0400 MIME-Version: 1.0 In-Reply-To: <1433321426-170133-1-git-send-email-wangnan0@huawei.com> References: <1433321426-170133-1-git-send-email-wangnan0@huawei.com> From: Namhyung Kim Date: Wed, 3 Jun 2015 21:30:53 +0900 X-Google-Sender-Auth: qgEBHzBWP4M6mTN7W4gAdr3sq8g Message-ID: Subject: Re: [PATCH tip] perf tools: Fix a compiling problem To: Wang Nan Cc: Jiri Olsa , Arnaldo Carvalho de Melo , Ingo Molnar , Li Zefan , pi3orama@163.com, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1499 Lines: 47 Hi Wang, On Wed, Jun 3, 2015 at 5:50 PM, Wang Nan wrote: > Commit 4bb11d012ab248d0e383008d725be0d26a74fac2 ("perf tools: Add > dso__data_get/put_fd()") has a problem: it uses a undefined variable > 'dso' in find_proc_info(), which should be 'map->dso'. The buggy code > piece is not compiled if NO_LIBUNWIND_DEBUG_FRAME is not set. > > Signed-off-by: Wang Nan Acked-by: Namhyung Kim Thanks for fixing this! Namhyung > --- > tools/perf/util/unwind-libunwind.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c > index f079b63..4c00507 100644 > --- a/tools/perf/util/unwind-libunwind.c > +++ b/tools/perf/util/unwind-libunwind.c > @@ -360,7 +360,7 @@ find_proc_info(unw_addr_space_t as, unw_word_t ip, unw_proc_info_t *pi, > unw_word_t base = is_exec ? 0 : map->start; > > if (fd >= 0) > - dso__data_put_fd(dso); > + dso__data_put_fd(map->dso); > > memset(&di, 0, sizeof(di)); > if (dwarf_find_debug_frame(0, &di, ip, base, map->dso->name, > -- > 1.8.3.4 > -- Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/