Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759589AbbFCM4q (ORCPT ); Wed, 3 Jun 2015 08:56:46 -0400 Received: from mail-qk0-f177.google.com ([209.85.220.177]:33053 "EHLO mail-qk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759362AbbFCMxv (ORCPT ); Wed, 3 Jun 2015 08:53:51 -0400 MIME-Version: 1.0 In-Reply-To: <20150603050810.GB3884@gondor.apana.org.au> References: <1432844491-27174-1-git-send-email-ddstreet@ieee.org> <20150603050810.GB3884@gondor.apana.org.au> From: Dan Streetman Date: Wed, 3 Jun 2015 08:53:29 -0400 X-Google-Sender-Auth: v_A7ISSAXbq79jxQCOSVNALIGAw Message-ID: Subject: Re: [PATCH] crypto: prevent nx 842 load if no hw driver To: Herbert Xu Cc: linux-kernel , Linux Crypto Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1915 Lines: 41 On Wed, Jun 3, 2015 at 1:08 AM, Herbert Xu wrote: > On Thu, May 28, 2015 at 04:21:31PM -0400, Dan Streetman wrote: >> Change the nx-842 common driver to wait for loading of both platform >> drivers, and fail loading if the platform driver pointer is not set. >> Add an independent platform driver pointer, that the platform drivers >> set if they find they are able to load (i.e. if they find their platform >> devicetree node(s)). >> >> The problem is currently, the main nx-842 driver will stay loaded even >> if there is no platform driver and thus no possible way it can do any >> compression or decompression. This allows the crypto 842-nx driver >> to load even if it won't actually work. For crypto compression users >> (e.g. zswap) that expect an available crypto compression driver to >> actually work, this is bad. This patch fixes that, so the 842-nx crypto >> compression driver won't load if it doesn't have the driver and hardware >> available to perform the compression. >> >> Signed-off-by: Dan Streetman > > Applied. Though I had to do the Makefile bit by hand because > it contains references to nx-compress-test which doesn't exist > in my tree. Oops sorry, I forgot to remove that old test module patch from my tree. Thanks. > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > -- > To unsubscribe from this list: send the line "unsubscribe linux-crypto" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/