Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754726AbbFCN05 (ORCPT ); Wed, 3 Jun 2015 09:26:57 -0400 Received: from mail.kernel.org ([198.145.29.136]:54850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754064AbbFCN0y (ORCPT ); Wed, 3 Jun 2015 09:26:54 -0400 Date: Wed, 3 Jun 2015 10:26:49 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: Jiri Olsa , Sukadev Bhattiprolu , mingo@redhat.com, Michael Ellerman , namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 12/14] perf, tools: Add support for event list topics Message-ID: <20150603132649.GV624@kernel.org> References: <1433265135-20426-1-git-send-email-sukadev@linux.vnet.ibm.com> <1433265135-20426-13-git-send-email-sukadev@linux.vnet.ibm.com> <20150602191641.GA3978@us.ibm.com> <20150603103229.GK1828@krava.redhat.com> <20150603125733.GS1187@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150603125733.GS1187@tassilo.jf.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 704 Lines: 17 Em Wed, Jun 03, 2015 at 05:57:33AM -0700, Andi Kleen escreveu: > > please split at least the jevents Topic parsing from the rest > > idelay also the alias update and the display change > > What's the point of all these splits? It's already one logical unit, > not too large, and is bisectable. Eases review, improves bisectability, and its a reasonable request from a reviewer/maintainer that has to look at an evergrowing number of patch flows. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/