Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756108AbbFCQXH (ORCPT ); Wed, 3 Jun 2015 12:23:07 -0400 Received: from mga02.intel.com ([134.134.136.20]:51691 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753233AbbFCQW6 (ORCPT ); Wed, 3 Jun 2015 12:22:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,547,1427785200"; d="scan'208";a="704719675" Date: Wed, 3 Jun 2015 09:34:47 -0700 From: Bin Gao To: Peter Hurley Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Greg Kroah-Hartman , "Stuart R. Anderson" , One Thousand Gnomes , Jiri Slaby , Borislav Petkov , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c Message-ID: <20150603163447.GA149091@worksta> References: <20150529184123.GB13090@worksta> <556EF491.8010408@hurleysoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <556EF491.8010408@hurleysoftware.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 44 On Wed, Jun 03, 2015 at 08:35:29AM -0400, Peter Hurley wrote: > > +/* x86 uses "earlyprintk=xxx", so we keep the compatibility here */ > > +#ifdef CONFIG_X86 > > +static int __init param_setup_earlycon_x86(char *buf) > > +{ > > + return param_setup_earlycon(buf); > > +} > > +early_param("earlyprintk", param_setup_earlycon_x86); > > I'm concerned that this effectively makes earlyprintk= a synonym for > earlycon=, which may have unforeseen consequences. I'd rather this > specifically parse for replacement functionality, ie., only command line > parameters of the form: > > earlyprintk=pciserial,... > > Regards, > Peter Hurley > Something like this: ? /* * x86 uses "earlyprintk=xxx", so we keep the compatibility here. * But we only handle the earlyprintk=uart8250,pci[32]B:D.F[,options] case. */ #ifdef CONFIG_X86 static int __init param_setup_earlycon_x86(char *buf) { if (strncmp("uart8250,pci", 12)) return -EINVAL; return param_setup_earlycon(buf); } early_param("earlyprintk", param_setup_earlycon_x86); Thanks, Bin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/