Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932297AbbFCQtH (ORCPT ); Wed, 3 Jun 2015 12:49:07 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:50092 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753315AbbFCQs7 (ORCPT ); Wed, 3 Jun 2015 12:48:59 -0400 Date: Wed, 3 Jun 2015 10:48:51 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: peterhuewe@gmx.de, safford@us.ibm.com, Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list , richard.l.maliszewski@intel.com Subject: Re: [PATCH] tpm: introduce struct tpm_buf Message-ID: <20150603164851.GA2222@obsidianresearch.com> References: <1433250262-17200-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20150602181315.GE17776@obsidianresearch.com> <20150603122331.GA3542@jsakkine-mobl1> <20150603161128.GB12073@obsidianresearch.com> <20150603164334.GA2327@jsakkine-mobl1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150603164334.GA2327@jsakkine-mobl1> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.192 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 20 On Wed, Jun 03, 2015 at 07:43:34PM +0300, Jarkko Sakkinen wrote: > I realized basically the same what you said here when I refined the > patch (read this email after sending v2) :) I decided that align to 8 > bytes. Don't use the __attribute__((align)), use just a u64, the effect is identical, and the latter doesn't rely on compiler specific features. > I don't think the packed attribute is needed here because now I cast > the beginning to tpm_input_header, which is a packed struct. I ment the attributs could be changed on the tpm_input_header, the buf should just be a u64 array.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/