Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933115AbbFCRGH (ORCPT ); Wed, 3 Jun 2015 13:06:07 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:32992 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933048AbbFCRF6 (ORCPT ); Wed, 3 Jun 2015 13:05:58 -0400 MIME-Version: 1.0 In-Reply-To: <20150603110241.GK1715@piout.net> References: <1433280853-3988-1-git-send-email-octavian.purdila@intel.com> <20150603110241.GK1715@piout.net> Date: Wed, 3 Jun 2015 20:05:56 +0300 Message-ID: Subject: Re: [PATCH 0/2] change "client->irq >= 0" to "client->irq > 0" From: Octavian Purdila To: Alexandre Belloni Cc: Linus Walleij , Mika Westerberg , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Alessandro Zummo , Srinivas Pandruvada , "linux-iio@vger.kernel.org" , rtc-linux@googlegroups.com, lkml Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1343 Lines: 31 On Wed, Jun 3, 2015 at 2:02 PM, Alexandre Belloni wrote: > On 03/06/2015 at 00:34:11 +0300, Octavian Purdila wrote : >> This fixes an issue introduces by commit dab472eb931b ("i2c / ACPI: >> Use 0 to indicate that device does not have interrupt assigned") where >> drivers will try to request IRQ 0 when no GpioInt is defined in ACPI. >> >> The same issue occurs when the device is instantiated via device tree >> with no IRQ, or from the i2c sysfs interface, even before the patch >> above. >> >> Linus, since the commit above was already merged in the GPIO tree, >> should these fixes be merged also via the GPIO tree (with ACKs from >> the others subsystem maintainers)? >> > > Side question, has it been considered that IRQ 0 is valid on some > platform and that means i2c devices will not be able to be wired to that > IRQ anymore? Though, I don't think there are any existing design that > does so. > Device tree instantiation does not allow you to used IRQ 0 anyway. And here is what Linus said about this: http://yarchive.net/comp/linux/no_irq.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/