Message-ID: <1433351196.4861.131.camel@perches.com>
Subject: Re: [PATCH v2 1/2] net/xen-netfront: Correct printf format in
 xennet_get_responses
From: Joe Perches <joe@perches.com>
To: Julien Grall <julien.grall@citrix.com>
Cc: xen-devel@lists.xenproject.org, ian.campbell@citrix.com,
        stefano.stabellini@eu.citrix.com, linux-kernel@vger.kernel.org,
        David Vrabel <david.vrabel@citrix.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>, netdev@vger.kernel.org
Date: Wed, 03 Jun 2015 10:06:36 -0700
In-Reply-To: <1433350510-12846-2-git-send-email-julien.grall@citrix.com>
References: <1433350510-12846-1-git-send-email-julien.grall@citrix.com>
	 <1433350510-12846-2-git-send-email-julien.grall@citrix.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 998
Lines: 25

On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote:
> rx->status is an int16_t, print it using %d rather than %u in order to
> have a meaningful value when the field is negative.
[]
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
[]
> @@ -733,7 +733,7 @@ static int xennet_get_responses(struct netfront_queue *queue,
>  		if (unlikely(rx->status < 0 ||
>  			     rx->offset + rx->status > PAGE_SIZE)) {
>  			if (net_ratelimit())
> -				dev_warn(dev, "rx->offset: %x, size: %u\n",
> +				dev_warn(dev, "rx->offset: %x, size: %d\n",

If you're going to do this, perhaps it'd be sensible to
also change the %x to %#x or 0x%x so that people don't
mistake offset without an [a-f] for decimal.

>  					 rx->offset, rx->status);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/