Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933057AbbFCTOO (ORCPT ); Wed, 3 Jun 2015 15:14:14 -0400 Received: from smtp10.smtpout.orange.fr ([80.12.242.132]:47162 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932721AbbFCTOF (ORCPT ); Wed, 3 Jun 2015 15:14:05 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 03 Jun 2015 21:14:01 +0200 X-ME-IP: 90.5.12.87 From: Robert Jarzmik To: Antoine Tenart Cc: sebastian.hesselbarth@gmail.com, ezequiel.garcia@free-electrons.com, dwmw2@infradead.org, computersforpeace@gmail.com, zmxu@marvell.com, boris.brezillon@free-electrons.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/7] Documentation: bindings: document the clocks for pxa3xx-nand References: <1433266351-22587-1-git-send-email-antoine.tenart@free-electrons.com> <1433266351-22587-3-git-send-email-antoine.tenart@free-electrons.com> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 03 Jun 2015 21:12:28 +0200 In-Reply-To: <1433266351-22587-3-git-send-email-antoine.tenart@free-electrons.com> (Antoine Tenart's message of "Tue, 2 Jun 2015 19:32:26 +0200") Message-ID: <87fv6861yb.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 736 Lines: 24 Antoine Tenart writes: > The pxa3xx nand driver requires at least one clock to probe correctly. > A second one, named 'ecc' can be specified if needed. Add the > corresponding documentation. Is it mandatory, really ? The code does : info->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(info->clk)) { dev_err(&pdev->dev, "failed to get nand clock\n"); return PTR_ERR(info->clk); } info->clk can very well be NULL, can't it ? Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/