Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758640AbbFCTZg (ORCPT ); Wed, 3 Jun 2015 15:25:36 -0400 Received: from smtp10.smtpout.orange.fr ([80.12.242.132]:47915 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbbFCTZ3 (ORCPT ); Wed, 3 Jun 2015 15:25:29 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 03 Jun 2015 21:25:26 +0200 X-ME-IP: 90.5.12.87 From: Robert Jarzmik To: Antoine Tenart Cc: sebastian.hesselbarth@gmail.com, ezequiel.garcia@free-electrons.com, dwmw2@infradead.org, computersforpeace@gmail.com, zmxu@marvell.com, boris.brezillon@free-electrons.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/7] mtd: pxa3xx_nand: add a non mandatory ECC clock References: <1433266351-22587-1-git-send-email-antoine.tenart@free-electrons.com> <1433266351-22587-2-git-send-email-antoine.tenart@free-electrons.com> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 03 Jun 2015 21:23:58 +0200 In-Reply-To: <1433266351-22587-2-git-send-email-antoine.tenart@free-electrons.com> (Antoine Tenart's message of "Tue, 2 Jun 2015 19:32:25 +0200") Message-ID: <87bngw61f5.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1331 Lines: 34 Antoine Tenart writes: > Some controllers (as the coming Berlin nand controller) need to enable > an ECC clock. Add support for this clock in the pxa3xx nand driver, and > leave it as non mandatory. > - info->clk = devm_clk_get(&pdev->dev, NULL); > + info->clk = devm_clk_get(&pdev->dev, "nfc"); > if (IS_ERR(info->clk)) { > - dev_err(&pdev->dev, "failed to get nand clock\n"); > - return PTR_ERR(info->clk); > + info->clk = devm_clk_get(&pdev->dev, NULL); > + > + if (IS_ERR(info->clk)) { > + dev_err(&pdev->dev, "failed to get nand clock\n"); > + return PTR_ERR(info->clk); > + } I suppose this is done to keep the compatibility with existing pxa3xx/berlin clock code, which was defined without a con_id. More specifically I'm thinking of the function clk_find(). Now maybe it would be cleaner to keep you "nfc" change, remove the failback plan with NULL as an con_id, and change the clock providers. I cannot speak for berlin/others, but for pxa3xx, this is one 3 hunks change in : - drivers/clk/pxa/clk-pxa3xx.c Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/