Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753652AbbFCXCL (ORCPT ); Wed, 3 Jun 2015 19:02:11 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:1048 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752126AbbFCXCF (ORCPT ); Wed, 3 Jun 2015 19:02:05 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 03 Jun 2015 15:58:18 -0700 Date: Wed, 3 Jun 2015 16:02:02 -0700 From: John Hubbard To: Jerome Glisse CC: , , , Linus Torvalds , , Mel Gorman , "H. Peter Anvin" , Peter Zijlstra , Andrea Arcangeli , Johannes Weiner , Larry Woodman , Rik van Riel , Dave Airlie , Brendan Conoboy , Joe Donohue , Duncan Poole , Sherry Cheung , Subhash Gutti , Mark Hairgrove , Lucien Dunning , "Cameron Buschardt" , Arvind Gopalakrishnan , Haggai Eran , Shachar Raindel , Liran Liss , Roland Dreier , Ben Sander , Greg Stoner , John Bridgman , Michael Mantor , Paul Blinzer , "Laurent Morichetti" , Alexander Deucher , Oded Gabbay , =?ISO-8859-15?Q?J=E9r=F4me_Glisse?= Subject: Re: [PATCH 01/36] mmu_notifier: add event information to address invalidation v7 In-Reply-To: <20150603160711.GA2602@gmail.com> Message-ID: References: <1432236705-4209-1-git-send-email-j.glisse@gmail.com> <1432236705-4209-2-git-send-email-j.glisse@gmail.com> <20150601190331.GA4170@gmail.com> <20150603160711.GA2602@gmail.com> User-Agent: Alpine 2.03 (LNX 1266 2009-07-14) X-NVConfidentiality: public MIME-Version: 1.0 X-Originating-IP: [172.16.180.125] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To DRHQMAIL105.nvidia.com (10.27.9.14) Content-Type: multipart/mixed; boundary="279739828-1836793317-1433372523=:980" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2478 Lines: 60 --279739828-1836793317-1433372523=:980 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT On Wed, 3 Jun 2015, Jerome Glisse wrote: > On Mon, Jun 01, 2015 at 04:10:46PM -0700, John Hubbard wrote: > > On Mon, 1 Jun 2015, Jerome Glisse wrote: > > > On Fri, May 29, 2015 at 08:43:59PM -0700, John Hubbard wrote: > > > > On Thu, 21 May 2015, j.glisse@gmail.com wrote: > > > > > From: J?r?me Glisse > > [...] > > > > We may have to add MMU_READ_WRITE (and maybe another one, I haven't > > > > bottomed out on that), if you agree with the above approach of > > > > always sending a precise event, instead of "protection changed". > > > > > > I think Linus point made sense last time, but i would need to read > > > again the thread. The idea of that patch is really to provide context > > > information on what kind of CPU page table changes is happening and > > > why. > > > > > > > Shoot, I tried to find that conversation, but my search foo is too weak. > > If you have a link to that thread, I'd appreciate it, so I can refresh my > > memory. > > > > I was hoping to re-read it and see if anything has changed. It's not > > really a huge problem to call find_vma() again, but I do want to be sure > > that there's a good reason for doing so. > > > > Otherwise, I'll just rely on your memory that Linus preferred your current > > approach, and call it good, then. > > http://lkml.iu.edu/hypermail/linux/kernel/1406.3/04880.html > > I am working on doing some of the changes discussed so far, i will push my > tree to git://people.freedesktop.org/~glisse/linux hmm branch once i am done. Aha, OK, that was back when you were passing around the vma. But now, you're not doing that anymore. It's just: mm*, range* (start, end, event_type), and sometimes page* and exclude*). So I think it's still reasonable to either pass down pure vma flags, or else add in new event types, in order to avoid having to lookup the vma later. We could still get NAK'd for adding ugly new event types, but if you're going to add the event types at all, let's make them complete, so that we really *earn* the NAK. :) > > Cheers, > J?r?me > --279739828-1836793317-1433372523=:980-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/