Date: Thu, 4 Jun 2015 10:04:54 +0900
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] workqueue: introduce get_pwq_unlocked()
Message-ID: <20150604010454.GJ20091@mtj.duckdns.org>
References: <1433341792-2017-1-git-send-email-laijs@cn.fujitsu.com>
 <1433341792-2017-2-git-send-email-laijs@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1433341792-2017-2-git-send-email-laijs@cn.fujitsu.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1099
Lines: 36

Hello,

On Wed, Jun 03, 2015 at 10:29:49PM +0800, Lai Jiangshan wrote:
> attrs management code may reuse existed pwq and it has open code

                                  existing

> to do "lock();get_pwq();unlock()", we move this open code into
> get_pwq_unlocked().
> 
> get_pwq_unlocked() will also be used in later patches to allow
> apply_wqattrs_prepare() to resue the original default or per-node pwq.

                             reuse

>  /**
> + * get_pwq_unlocked - get_pwq() with surrounding pool lock/unlock
> + * @pwq: pool_workqueue to get (should not %NULL)

                                   should not be %NULL

> + *
> + * get_pwq() with locking.  The caller should have at least an owned
> + * reference on @pwq to match the guarantees required by get_pwq().

      The caller should have a reference on @pwq.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/