Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752457AbbFDIZ4 (ORCPT ); Thu, 4 Jun 2015 04:25:56 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:34647 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752353AbbFDIZD (ORCPT ); Thu, 4 Jun 2015 04:25:03 -0400 From: Grant Likely Subject: Re: [PATCH] of/fdt: fix argument name and add comments of unflatten_dt_node() To: Masahiro Yamada , devicetree@vger.kernel.org Cc: Masahiro Yamada , Rob Herring , linux-kernel@vger.kernel.org In-Reply-To: <1428888620-307-1-git-send-email-yamada.masahiro@socionext.com> References: <1428888620-307-1-git-send-email-yamada.masahiro@socionext.com> Date: Thu, 04 Jun 2015 14:53:28 +0900 Message-Id: <20150604055328.6F296C4095F@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1531 Lines: 46 On Mon, 13 Apr 2015 10:30:20 +0900 , Masahiro Yamada wrote: > Match the name of the third argument in the comment block > to the actual function: p -> poffset > > Add missing comments about the arguments "nodepp" and "dryrun". > > Signed-off-by: Masahiro Yamada Applied, thanks. g. > --- > > drivers/of/fdt.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index 3a896c9..35898ca 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -145,9 +145,12 @@ static void *unflatten_dt_alloc(void **mem, unsigned long size, > * unflatten_dt_node - Alloc and populate a device_node from the flat tree > * @blob: The parent device tree blob > * @mem: Memory chunk to use for allocating device nodes and properties > - * @p: pointer to node in flat tree > + * @poffset: pointer to node in flat tree > * @dad: Parent struct device_node > + * @nodepp: The device_node tree created by the call > * @fpsize: Size of the node path up at the current depth. > + * @dryrun: If true, do not allocate device nodes but still calculate needed > + * memory size > */ > static void * unflatten_dt_node(void *blob, > void *mem, > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/